38b38d1fcc
Having a class named `Poll::Question::Answer` and another class named `Poll::Answer` was so confusing that no developer working on the project has ever been capable of remembering which is which for more than a few seconds. Furthermore, we're planning to add open answers to polls, and we might add a reference from the `poll_answers` table to the `poll_question_answers` table to property differentiate between open answers and closed answers. Having yet another thing named answer would be more than what our brains can handle (we know it because we did this once in a prototype). So we're renaming `Poll::Question::Answer` to `Poll::Question::Option`. Hopefully that'll make it easier to remember. The name is also (more or less) consistent with the `Legislation::QuestionOption` class, which is similar. We aren't changing the table or columns names for now in order to avoid possible issues when upgrading (old code running with the new database tables/columns after running the migrations but before deployment has finished, for instance). We might do it in the future. I've tried not to change the internationalization keys either so existing translations would still be valid. However, since we have to change the keys in `activerecord.yml` so methods like `human_attribute_name` keep working, I'm also changing them in places where similar keys were used (like `poll_question_answer` or `poll/question/answer`). Note that it isn't clear whether we should use `option` or `question_option` in some cases. In order to keep things simple, we're using `option` where we were using `answer` and `question_option` where we were using `question_answer`. Also note we're adding tests for the admin menu component, since at first I forgot to change the `answers` reference there and all tests passed.
39 lines
1.2 KiB
Ruby
39 lines
1.2 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Admin::MenuComponent, controller: Admin::NewslettersController do
|
|
it "disables all buttons when JavaScript isn't available" do
|
|
render_inline Admin::MenuComponent.new
|
|
|
|
expect(page).to have_button disabled: true
|
|
expect(page).not_to have_button disabled: false
|
|
end
|
|
|
|
it "expands the current section" do
|
|
render_inline Admin::MenuComponent.new
|
|
|
|
expect(page).to have_css "button[aria-expanded='true']", exact_text: "Messages to users"
|
|
end
|
|
|
|
it "does not expand other sections" do
|
|
render_inline Admin::MenuComponent.new
|
|
|
|
expect(page).to have_css "button[aria-expanded='false']", exact_text: "Settings"
|
|
end
|
|
|
|
describe "#polls_link" do
|
|
it "is marked as current when managing poll options",
|
|
controller: Admin::Poll::Questions::OptionsController do
|
|
render_inline Admin::MenuComponent.new
|
|
|
|
expect(page).to have_css "[aria-current]", exact_text: "Polls"
|
|
end
|
|
|
|
it "is marked as current when managing poll options content",
|
|
controller: Admin::Poll::Questions::Options::VideosController do
|
|
render_inline Admin::MenuComponent.new
|
|
|
|
expect(page).to have_css "[aria-current]", exact_text: "Polls"
|
|
end
|
|
end
|
|
end
|