51a0bce58c
Both the calculate winners and delete actions benefit from some kind of hint. The "calculate winners" hint informs administrators that results won't be publicly available unless the "show results" option is enabled. The delete action was redirecting with an error message when the budget couldn't be deleted; IMHO it's better to disable it and inform administrators why it's disabled. Alternatively we could remove the button completely; however, users might be looking for a way to delete a budget and wouldn't find any hint about it. We're now removing the "Delete" action from the budgets index table, since most of the time it isn't possible to delete a budget and so the action takes up space and we get little gain in return. We could keep the "Delete" icon just for budgets which can be deleted; however, the alignment of the table rows would suffer, making it harder to find the intended action.
182 lines
6.1 KiB
Ruby
182 lines
6.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Admin::ActionComponent do
|
|
describe "HTML class" do
|
|
it "includes an HTML class for the action by default" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/")
|
|
|
|
expect(page).to have_css "a.edit-link.admin-action"
|
|
end
|
|
|
|
it "keeps the admin-action class when the class is overwritten" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/", class: "modify-link")
|
|
|
|
expect(page).to have_css "a.modify-link.admin-action"
|
|
expect(page).not_to have_css ".edit-link"
|
|
end
|
|
end
|
|
|
|
describe "HTML id" do
|
|
it "is not rendered for non-ActiveModel records" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/")
|
|
|
|
expect(page).not_to have_css "[id]"
|
|
end
|
|
|
|
it "includes an id based on the model and the action by default" do
|
|
record = double(model_name: double(param_key: "computer"), to_key: [1])
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/")
|
|
|
|
expect(page).to have_css "a.edit-link#edit_computer_1"
|
|
end
|
|
|
|
it "can be overwritten" do
|
|
record = double(model_name: double(param_key: "computer"), to_key: [1])
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/", id: "my_id")
|
|
|
|
expect(page).to have_css "a.edit-link#my_id"
|
|
expect(page).not_to have_css "#edit_computer_1"
|
|
end
|
|
end
|
|
|
|
describe "aria-describedby attribute" do
|
|
it "is not rendered by default" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/")
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).not_to have_css "[aria-describedby]"
|
|
end
|
|
|
|
it "renders with the given value" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/", "aria-describedby": "my_descriptor")
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "[aria-describedby='my_descriptor']"
|
|
end
|
|
|
|
it "renders a default value when aria-describedby is true" do
|
|
record = double(model_name: double(param_key: "book"), to_key: [23])
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/", "aria-describedby": true)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "[aria-describedby='edit_book_23_descriptor']"
|
|
end
|
|
end
|
|
|
|
describe "aria-label attribute" do
|
|
it "is not rendered by default" do
|
|
record = double(human_name: "Stay home")
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/")
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).not_to have_css "[aria-label]"
|
|
end
|
|
|
|
it "is not rendered when aria-label is nil" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/", "aria-label": nil)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).not_to have_css "[aria-label]"
|
|
end
|
|
|
|
it "renders with the given value" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/", "aria-label": "Modify")
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "[aria-label='Modify']"
|
|
end
|
|
|
|
context "when aria-label is true" do
|
|
it "includes the action and the human_name of the record" do
|
|
record = double(human_name: "Stay home")
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/", "aria-label": true)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "a[aria-label='Edit Stay home']", exact_text: "Edit"
|
|
end
|
|
|
|
it "uses the to_s method when there's no human_name" do
|
|
record = double(to_s: "do_not_go_out")
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/", "aria-label": true)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "a[aria-label='Edit Do not go out']", exact_text: "Edit"
|
|
end
|
|
|
|
it "uses the human_name when there are both human_name and to_s" do
|
|
record = double(human_name: "Stay home", to_s: "do_not_go_out")
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/", "aria-label": true)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "a[aria-label='Edit Stay home']", exact_text: "Edit"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "data-confirm attribute" do
|
|
it "is not rendered by default" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/")
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).not_to have_css "[data-confirm]"
|
|
end
|
|
|
|
it "is not rendered when confirm is nil" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/", confirm: nil)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).not_to have_css "[data-confirm]"
|
|
end
|
|
|
|
it "renders with the given value" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/", confirm: "Really?")
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "[data-confirm='Really?']"
|
|
end
|
|
|
|
context "when confirm is true" do
|
|
it "uses the human name as default" do
|
|
record = double(human_name: "Everywhere and nowhere")
|
|
text = 'Are you sure? Edit "Everywhere and nowhere"'
|
|
|
|
render_inline Admin::ActionComponent.new(:edit, record, path: "/", confirm: true)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "[data-confirm='#{text}']"
|
|
end
|
|
|
|
it "includes a more detailed message for the destroy action" do
|
|
record = double(human_name: "Participatory Budget 2015")
|
|
text = 'Are you sure? This action will delete "Participatory Budget 2015" and can\\\'t be undone.'
|
|
|
|
render_inline Admin::ActionComponent.new(:destroy, record, path: "/", confirm: true)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "[data-confirm='#{text}']"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "data-disable-with attribute" do
|
|
it "is not rendered for links" do
|
|
render_inline Admin::ActionComponent.new(:edit, double, path: "/")
|
|
|
|
expect(page).not_to have_css "[data-disable-with]"
|
|
end
|
|
|
|
it "is rendered for buttons" do
|
|
render_inline Admin::ActionComponent.new(:hide, double, path: "/", method: :delete)
|
|
|
|
expect(page).to have_css "button[data-disable-with='Hide']"
|
|
end
|
|
end
|
|
end
|