bb958daf05
Using links combined with JavaScript to generate POST requests to the browser has a few issues. An obvious one is that it doesn't work for users without JavaScript enabled (which lately I've noticed are more common than I thought, even though I've been one of them for years). These users will reach a 404 page. Since CONSUL isn't currently designed to work without JavaScript enabled, let's ignore this one for now. A not so obvious issue is screen reader users might expect the link to take them somewhere instead of performing an action (in this case, sending a form to the server). There might be more issues I'm unaware of. Quoting DHH [1]: "Turning ahrefs into POSTs is a bit of an anti-pattern, especially for a11y reasons. Better to use button_to with a styling." So we're using a button instead. This way we can also simplify the code and make the button disabled for unidentified users, which automatically makes it impossible to focus it using the keyboard. A possible disadvantage of using `button_to` is it will create a form tag which will be announced to screen readers as a form landmark. I've tested it with my screen reader and everything worked fine for me, but some screen reader users might interact with these forms in a different way and find it confusing, particularly in the case where the button is disabled. With this change, we're only changing links for buttons in one place. There are other places where we should do similar changes. [1] See issue 33 in https://github.com/hotwired/turbo-rails/
231 lines
8.4 KiB
Ruby
231 lines
8.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Votes" do
|
|
let(:manuela) { create(:user, verified_at: Time.current) }
|
|
|
|
context "Investments - Knapsack" do
|
|
let(:budget) { create(:budget, phase: "selecting") }
|
|
let(:group) { create(:budget_group, budget: budget) }
|
|
let(:heading) { create(:budget_heading, group: group) }
|
|
|
|
before { login_as(manuela) }
|
|
|
|
describe "Index" do
|
|
scenario "Index shows user votes on proposals" do
|
|
investment1 = create(:budget_investment, heading: heading, voters: [manuela])
|
|
investment2 = create(:budget_investment, heading: heading)
|
|
investment3 = create(:budget_investment, heading: heading)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within("#budget-investments") do
|
|
within("#budget_investment_#{investment1.id}_votes") do
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
within("#budget_investment_#{investment2.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
within("#budget_investment_#{investment3.id}_votes") do
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Create from investments' index" do
|
|
create(:budget_investment, heading: heading)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within(".supports") do
|
|
click_button "Support"
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Single investment" do
|
|
let(:investment) { create(:budget_investment, heading: heading) }
|
|
|
|
scenario "Show no votes" do
|
|
visit budget_investment_path(budget, investment)
|
|
expect(page).to have_content "No supports"
|
|
end
|
|
|
|
scenario "Trying to vote multiple times" do
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within(".supports") do
|
|
click_button "Support"
|
|
|
|
expect(page).not_to have_button "Support", disabled: :all
|
|
expect(page).to have_content "1 support"
|
|
end
|
|
end
|
|
|
|
scenario "Create from investment show" do
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within(".supports") do
|
|
click_button "Support"
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Disable voting on investments" do
|
|
budget.update!(phase: "reviewing")
|
|
investment = create(:budget_investment, heading: heading)
|
|
|
|
manuela = create(:user, verified_at: Time.current)
|
|
login_as(manuela)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
within("#budget_investment_#{investment.id}") do
|
|
expect(page).not_to have_css("budget_investment_#{investment.id}_votes")
|
|
end
|
|
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within("#budget_investment_#{investment.id}") do
|
|
expect(page).not_to have_css("budget_investment_#{investment.id}_votes")
|
|
end
|
|
end
|
|
|
|
context "Voting in multiple headings of a single group" do
|
|
let(:new_york) { heading }
|
|
let(:san_francisco) { create(:budget_heading, group: group) }
|
|
let(:third_heading) { create(:budget_heading, group: group) }
|
|
|
|
let!(:new_york_investment) { create(:budget_investment, heading: new_york) }
|
|
let!(:san_francisco_investment) { create(:budget_investment, heading: san_francisco) }
|
|
let!(:third_heading_investment) { create(:budget_investment, heading: third_heading) }
|
|
|
|
before do
|
|
group.update(max_votable_headings: 2)
|
|
end
|
|
|
|
scenario "From Index" do
|
|
visit budget_investments_path(budget, heading_id: new_york.id)
|
|
|
|
within("#budget_investment_#{new_york_investment.id}") do
|
|
accept_confirm { click_button "Support" }
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
visit budget_investments_path(budget, heading_id: san_francisco.id)
|
|
|
|
within("#budget_investment_#{san_francisco_investment.id}") do
|
|
click_button "Support"
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
visit budget_investments_path(budget, heading_id: third_heading.id)
|
|
|
|
within("#budget_investment_#{third_heading_investment.id}") do
|
|
click_button "Support"
|
|
|
|
expect(page).to have_content "You can only support investment projects in 2 districts. "\
|
|
"You have already supported investments in"
|
|
|
|
participation = find(".participation-not-allowed")
|
|
headings = participation.text
|
|
.match(/You have already supported investments in (.+) and (.+)\./)&.captures
|
|
|
|
expect(headings).to match_array [new_york.name, san_francisco.name]
|
|
|
|
expect(page).not_to have_content "1 support"
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
end
|
|
|
|
scenario "From show" do
|
|
visit budget_investment_path(budget, new_york_investment)
|
|
|
|
accept_confirm { click_button "Support" }
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. Share it!"
|
|
|
|
visit budget_investment_path(budget, san_francisco_investment)
|
|
|
|
click_button "Support"
|
|
|
|
expect(page).to have_content "1 support"
|
|
expect(page).to have_content "You have already supported this investment project. Share it!"
|
|
|
|
visit budget_investment_path(budget, third_heading_investment)
|
|
|
|
click_button "Support"
|
|
|
|
expect(page).to have_content "You can only support investment projects in 2 districts. "\
|
|
"You have already supported investments in"
|
|
|
|
participation = find(".participation-not-allowed")
|
|
headings = participation.text
|
|
.match(/You have already supported investments in (.+) and (.+)\./)&.captures
|
|
|
|
expect(headings).to match_array [new_york.name, san_francisco.name]
|
|
|
|
expect(page).not_to have_content "1 support"
|
|
expect(page).not_to have_content "You have already supported this investment project. "\
|
|
"Share it!"
|
|
end
|
|
|
|
scenario "Confirm message shows the right text" do
|
|
visit budget_investments_path(budget, heading_id: new_york.id)
|
|
click_button "Support"
|
|
|
|
expect(page.driver.send(:find_modal).text).to match "You can only support investments in 2 districts."
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Investments - Approval" do
|
|
let(:budget) { create(:budget, :balloting, :approval) }
|
|
before { login_as(manuela) }
|
|
|
|
scenario "Budget limit is ignored" do
|
|
group = create(:budget_group, budget: budget)
|
|
heading = create(:budget_heading, group: group, max_ballot_lines: 2)
|
|
investment1 = create(:budget_investment, :selected, heading: heading, price: heading.price)
|
|
investment2 = create(:budget_investment, :selected, heading: heading, price: heading.price)
|
|
|
|
visit budget_investments_path(budget, heading_id: heading.id)
|
|
|
|
add_to_ballot(investment1.title)
|
|
|
|
expect(page).to have_content("Remove vote")
|
|
expect(page).to have_content("YOU CAN STILL CAST 1 VOTE")
|
|
|
|
within(".budget-investment", text: investment2.title) do
|
|
find("div.ballot").hover
|
|
|
|
expect(page).not_to have_content("You have already assigned the available budget")
|
|
end
|
|
|
|
visit budget_ballot_path(budget)
|
|
|
|
expect(page).to have_content("you can change your vote at any time until this phase is closed")
|
|
end
|
|
end
|
|
end
|