bb958daf05
Using links combined with JavaScript to generate POST requests to the browser has a few issues. An obvious one is that it doesn't work for users without JavaScript enabled (which lately I've noticed are more common than I thought, even though I've been one of them for years). These users will reach a 404 page. Since CONSUL isn't currently designed to work without JavaScript enabled, let's ignore this one for now. A not so obvious issue is screen reader users might expect the link to take them somewhere instead of performing an action (in this case, sending a form to the server). There might be more issues I'm unaware of. Quoting DHH [1]: "Turning ahrefs into POSTs is a bit of an anti-pattern, especially for a11y reasons. Better to use button_to with a styling." So we're using a button instead. This way we can also simplify the code and make the button disabled for unidentified users, which automatically makes it impossible to focus it using the keyboard. A possible disadvantage of using `button_to` is it will create a form tag which will be announced to screen readers as a form landmark. I've tested it with my screen reader and everything worked fine for me, but some screen reader users might interact with these forms in a different way and find it confusing, particularly in the case where the button is disabled. With this change, we're only changing links for buttons in one place. There are other places where we should do similar changes. [1] See issue 33 in https://github.com/hotwired/turbo-rails/
33 lines
1.1 KiB
Ruby
33 lines
1.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Budgets::Investments::VotesComponent, type: :component do
|
|
describe "vote link" do
|
|
context "when investment shows votes" do
|
|
let(:investment) { create(:budget_investment, title: "Renovate sidewalks in Main Street") }
|
|
let(:component) do
|
|
Budgets::Investments::VotesComponent.new(investment, investment_votes: [], vote_url: "/")
|
|
end
|
|
|
|
before { allow(investment).to receive(:should_show_votes?).and_return(true) }
|
|
|
|
it "displays a button to support the investment to identified users" do
|
|
allow(controller).to receive(:current_user).and_return(create(:user))
|
|
|
|
render_inline component
|
|
|
|
expect(page).to have_button count: 1
|
|
expect(page).to have_button "Support", title: "Support this project", disabled: false
|
|
expect(page).to have_button "Support Renovate sidewalks in Main Street"
|
|
end
|
|
|
|
it "disables the button to support the investment to unidentified users" do
|
|
allow(controller).to receive(:current_user).and_return(nil)
|
|
|
|
render_inline component
|
|
|
|
expect(page).to have_button "Support", disabled: true
|
|
end
|
|
end
|
|
end
|
|
end
|