We were using buttons with the "Enable" and "Disable" texts to
enable/disable settings. However, when machine learning settings were
introduced in commit 4d27bbeba, a switch control was introduced to
enable/disable them.
In order to keep the interface consistent, we're now using switch
controls in other sections where settings are enabled/disabled. We can
even use the same code in the machine learning settings as well.
We're also removing the confirmation dialog to enable/disable a setting,
since the dialog is really annoying when changing several settings and
this action can be undone immediately. The only setting which might need
a confirmation is the "Skip user verification" one; we might add it in
the future. Removing the confirmation here doesn't make things worse,
though; the "Are you sure?" confirmation dialog was also pretty useless
and users would most likely blindly accept it.
Note Capybara doesn't support finding a button by its `aria-labelledby`
atrribute. Ideally we'd write `click_button "Participatory budgeting"`
instead of `click_button "Yes"`, since from the user's point of view the
"Yes" or "No" texts aren't button labels but indicators of the status of
the setting. This makes the code a little brittle since tests would pass
even if the element referenced by `aria-labelledby` didn't exist.
83 lines
1.3 KiB
SCSS
83 lines
1.3 KiB
SCSS
@import "mixins/colors";
|
|
|
|
@mixin base-button {
|
|
font-size: $base-font-size;
|
|
|
|
&:focus,
|
|
&:hover {
|
|
text-decoration: none !important;
|
|
}
|
|
|
|
&[disabled] {
|
|
@include button-disabled;
|
|
}
|
|
}
|
|
|
|
%button {
|
|
@include base-button;
|
|
}
|
|
|
|
@mixin regular-button($color: $brand) {
|
|
@include button($background: $color);
|
|
@include inverted-selection;
|
|
@include base-button;
|
|
}
|
|
|
|
@mixin hollow-button($color: $link) {
|
|
@include button($style: hollow, $background: $color);
|
|
@include normal-selection;
|
|
@include base-button;
|
|
margin-bottom: 0;
|
|
}
|
|
|
|
@mixin link {
|
|
color: $link;
|
|
cursor: pointer;
|
|
|
|
&:hover,
|
|
&:active {
|
|
color: $link-hover;
|
|
text-decoration: underline;
|
|
}
|
|
}
|
|
|
|
@mixin switch {
|
|
@include regular-button;
|
|
border-radius: $line-height;
|
|
font-weight: bold;
|
|
min-width: rem-calc(100);
|
|
position: relative;
|
|
|
|
&::after {
|
|
background: $white;
|
|
border-radius: 100%;
|
|
content: "";
|
|
display: block;
|
|
height: 1.75em;
|
|
position: absolute;
|
|
transform: translateY(-50%);
|
|
top: 50%;
|
|
width: 1.75em;
|
|
}
|
|
|
|
&[aria-pressed=true] {
|
|
background: $primary-color;
|
|
padding-right: 2.5em;
|
|
text-align: left;
|
|
|
|
&::after {
|
|
right: 0.5em;
|
|
}
|
|
}
|
|
|
|
&[aria-pressed=false] {
|
|
background: $dark-gray;
|
|
padding-left: 2.5em;
|
|
text-align: right;
|
|
|
|
&::after {
|
|
left: 0.5em;
|
|
}
|
|
}
|
|
}
|