d0d1c9972c
There's a very common pattern in our test, where the setup only has two lines: variable = create(:something) unused_variable = create(:something_else, something: variable) In this case, since there's a blank line below these ones and then we'll get to the body of the test, and the second variable is going to be created based on the first variable, we can remove the useless assignment and the readability is still OK. Another option we almost unanimously discarded was: variable = create(:something) _unused_variable = create(:something_else, something: variable) We don't use it anywhere else, either. One more option we considered but found a bit too much for simple tests: variable = create(:something) do |something| create(:something_else, something: variable) end Then of course we could move the setup to `let` and `before` blocks, but the tests could get over-structured really quickly.
204 lines
6.4 KiB
Ruby
204 lines
6.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Voters" do
|
|
|
|
let(:poll) { create(:poll, :current) }
|
|
let(:booth) { create(:poll_booth) }
|
|
let(:officer) { create(:poll_officer) }
|
|
|
|
before do
|
|
create(:geozone, :in_census)
|
|
create(:poll_shift, officer: officer, booth: booth, date: Date.current, task: :vote_collection)
|
|
create(:poll_officer_assignment, officer: officer, poll: poll, booth: booth)
|
|
login_as(officer.user)
|
|
set_officing_booth(booth)
|
|
end
|
|
|
|
scenario "Can vote", :js do
|
|
create(:poll_officer_assignment, officer: officer)
|
|
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content poll.name
|
|
|
|
click_button "Confirm vote"
|
|
|
|
expect(page).to have_content "Vote introduced!"
|
|
expect(page).not_to have_button "Confirm vote"
|
|
|
|
page.evaluate_script("window.location.reload()")
|
|
expect(page).to have_content "Has already participated in this poll"
|
|
expect(page).not_to have_button "Confirm vote"
|
|
|
|
expect(Poll::Voter.last.officer_id).to eq(officer.id)
|
|
end
|
|
|
|
scenario "Cannot vote" do
|
|
unvotable_poll = create(:poll, :current, geozone_restricted: true, geozones: [create(:geozone, census_code: "02")])
|
|
create(:poll_officer_assignment, officer: officer, poll: unvotable_poll, booth: booth)
|
|
|
|
set_officing_booth(booth)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
within("#poll_#{unvotable_poll.id}") do
|
|
expect(page).to have_content "The person cannot vote"
|
|
expect(page).not_to have_button "Confirm vote"
|
|
end
|
|
end
|
|
|
|
scenario "Already voted" do
|
|
poll2 = create(:poll, :current)
|
|
create(:poll_officer_assignment, officer: officer, poll: poll2, booth: booth)
|
|
|
|
user = create(:user, :level_two)
|
|
voter = create(:poll_voter, poll: poll, user: user)
|
|
|
|
visit new_officing_voter_path(id: voter.user.id)
|
|
|
|
within("#poll_#{poll.id}") do
|
|
expect(page).to have_content "Has already participated in this poll"
|
|
expect(page).not_to have_button "Confirm vote"
|
|
end
|
|
|
|
within("#poll_#{poll2.id}") do
|
|
expect(page).to have_button "Confirm vote"
|
|
end
|
|
end
|
|
|
|
scenario "Had already verified his residence, but is not level 2 yet", :js do
|
|
user = create(:user, residence_verified_at: Time.current, document_type: "1", document_number: "12345678Z")
|
|
expect(user).not_to be_level_two_verified
|
|
|
|
visit root_path
|
|
click_link "Sign out"
|
|
login_through_form_as_officer(officer.user)
|
|
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content poll.name
|
|
end
|
|
|
|
context "Polls displayed to officers" do
|
|
|
|
scenario "Display current polls assigned to a booth" do
|
|
poll = create(:poll, :current)
|
|
create(:poll_officer_assignment, officer: officer, poll: poll, booth: booth)
|
|
|
|
set_officing_booth(booth)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content poll.name
|
|
end
|
|
|
|
scenario "Display polls that the user can vote" do
|
|
votable_poll = create(:poll, :current, geozone_restricted: true, geozones: [Geozone.first])
|
|
create(:poll_officer_assignment, officer: officer, poll: votable_poll, booth: booth)
|
|
|
|
set_officing_booth(booth)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content votable_poll.name
|
|
end
|
|
|
|
scenario "Display polls that the user cannot vote" do
|
|
unvotable_poll = create(:poll, :current, geozone_restricted: true, geozones: [create(:geozone, census_code: "02")])
|
|
create(:poll_officer_assignment, officer: officer, poll: unvotable_poll, booth: booth)
|
|
|
|
set_officing_booth(booth)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content unvotable_poll.name
|
|
end
|
|
|
|
scenario "Do not display expired polls" do
|
|
expired_poll = create(:poll, :expired)
|
|
create(:poll_officer_assignment, officer: officer, poll: expired_poll, booth: booth)
|
|
|
|
set_officing_booth(booth)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).not_to have_content expired_poll.name
|
|
end
|
|
|
|
scenario "Do not display polls from other booths" do
|
|
poll1 = create(:poll, :current)
|
|
poll2 = create(:poll, :current)
|
|
|
|
booth1 = create(:poll_booth)
|
|
booth2 = create(:poll_booth)
|
|
|
|
create(:poll_officer_assignment, officer: officer, poll: poll1, booth: booth1)
|
|
create(:poll_officer_assignment, officer: officer, poll: poll2, booth: booth2)
|
|
|
|
set_officing_booth(booth1)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content poll1.name
|
|
expect(page).not_to have_content poll2.name
|
|
|
|
set_officing_booth(booth2)
|
|
visit new_officing_residence_path
|
|
officing_verify_residence
|
|
|
|
expect(page).to have_content "Polls"
|
|
expect(page).to have_content poll2.name
|
|
expect(page).not_to have_content poll1.name
|
|
end
|
|
end
|
|
|
|
scenario "Store officer and booth information", :js do
|
|
create(:user, :in_census, id: rand(9999999))
|
|
poll1 = create(:poll, name: "¿Quieres que XYZ sea aprobado?")
|
|
poll2 = create(:poll, name: "Pregunta de votación de prueba")
|
|
|
|
second_booth = create(:poll_booth)
|
|
|
|
ba1 = create(:poll_booth_assignment, poll: poll1, booth: second_booth)
|
|
ba2 = create(:poll_booth_assignment, poll: poll2, booth: second_booth)
|
|
create(:poll_shift, officer: officer, booth: second_booth, date: Date.current, task: :vote_collection)
|
|
|
|
validate_officer
|
|
visit new_officing_residence_path
|
|
set_officing_booth(second_booth)
|
|
officing_verify_residence
|
|
|
|
within("#poll_#{poll1.id}") do
|
|
click_button "Confirm vote"
|
|
|
|
expect(page).to have_content "Vote introduced!"
|
|
end
|
|
|
|
within("#poll_#{poll2.id}") do
|
|
click_button "Confirm vote"
|
|
|
|
expect(page).to have_content "Vote introduced!"
|
|
end
|
|
|
|
expect(Poll::Voter.count).to eq(2)
|
|
|
|
voter1 = Poll::Voter.first
|
|
|
|
expect(voter1.booth_assignment).to eq(ba1)
|
|
expect(voter1.officer_assignment).to eq(ba1.officer_assignments.first)
|
|
|
|
voter2 = Poll::Voter.last
|
|
expect(voter2.booth_assignment).to eq(ba2)
|
|
expect(voter2.officer_assignment).to eq(ba2.officer_assignments.first)
|
|
end
|
|
end
|