Files
grecia/spec/system/admin/hidden_comments_spec.rb
Javi Martín a31e73bf23 Ask for confirmation when hiding/blocking users
In the moderation section there's no clear indicator as to what the
"Hide" and "Block" buttons do and the difference between them.

Since we're using confirmation dialogs in all moderation actions except
these ones, we're adding them here as well, so the difference will
appear in the dialog.

This isn't a very good solution, though, since the confirmation dialog
comes after clicking the button and users have already been wondering
whether clicking that button will be the right choice. A better solution
would be making the purpose clear before the button is clicked, although
that's something we don't do anywhere in the admin/moderation sections.
2021-12-30 15:50:03 +01:00

139 lines
5.0 KiB
Ruby

require "rails_helper"
describe "Admin hidden comments", :admin do
scenario "Do not show comments from blocked users" do
comment = create(:comment, :hidden, body: "SPAM from SPAMMER")
proposal = create(:proposal, author: comment.author)
create(:comment, commentable: proposal, user: comment.author, body: "Good Proposal!")
visit admin_hidden_comments_path
expect(page).to have_content("SPAM from SPAMMER")
expect(page).not_to have_content("Good Proposal!")
visit proposal_path(proposal)
within("#proposal_#{proposal.id}") do
accept_confirm("Are you sure? This will hide the user \"#{proposal.author.name}\" and all their contents.") do
click_button "Block author"
end
end
expect(page).to have_current_path proposals_path
visit admin_hidden_comments_path
expect(page).not_to have_content("SPAM from SPAMMER")
expect(page).not_to have_content("Good Proposal!")
end
scenario "Visit items with hidden comments" do
debate = create(:debate, title: "Debate with spam comment")
proposal = create(:proposal, title: "Proposal with spam comment")
create(:comment, :hidden, commentable: debate, body: "This is SPAM comment on debate")
create(:comment, :hidden, commentable: proposal, body: "This is SPAM comment on proposal")
visit admin_hidden_comments_path
expect(page).to have_content("Debate with spam comment")
expect(page).to have_content("Proposal with spam comment")
expect(page).to have_content("This is SPAM comment on debate")
expect(page).to have_content("This is SPAM comment on proposal")
click_link "Debate with spam comment"
expect(page).to have_content("Debate with spam comment")
expect(page).not_to have_content("This is SPAM comment on debate")
visit admin_hidden_comments_path
click_link "Proposal with spam comment"
expect(page).to have_content("Proposal with spam comment")
expect(page).not_to have_content("This is SPAM comment on proposal")
end
scenario "Don't show link on hidden items" do
debate = create(:debate, :hidden, title: "Hidden debate title")
proposal = create(:proposal, :hidden, title: "Hidden proposal title")
create(:comment, :hidden, commentable: debate, body: "This is SPAM comment on debate")
create(:comment, :hidden, commentable: proposal, body: "This is SPAM comment on proposal")
visit admin_hidden_comments_path
expect(page).to have_content("(Hidden proposal: Hidden proposal title)")
expect(page).to have_content("(Hidden debate: Hidden debate title)")
expect(page).not_to have_link("This is SPAM comment on debate")
expect(page).not_to have_link("This is SPAM comment on proposal")
end
scenario "Restore" do
comment = create(:comment, :hidden, body: "Not really SPAM")
visit admin_hidden_comments_path
accept_confirm("Are you sure? Restore") { click_button "Restore" }
expect(page).not_to have_content(comment.body)
visit comment_path(comment)
expect(page).to have_content(comment.body)
end
scenario "Confirm hide" do
comment = create(:comment, :hidden, body: "SPAM")
visit admin_hidden_comments_path
click_button "Confirm moderation"
expect(page).not_to have_content(comment.body)
click_link("Confirmed")
expect(page).to have_content(comment.body)
end
scenario "Current filter is properly highlighted" do
visit admin_hidden_comments_path
expect(page).not_to have_link("Pending")
expect(page).to have_link("All")
expect(page).to have_link("Confirmed")
visit admin_hidden_comments_path(filter: "Pending")
expect(page).not_to have_link("Pending")
expect(page).to have_link("All")
expect(page).to have_link("Confirmed")
visit admin_hidden_comments_path(filter: "all")
expect(page).to have_link("Pending")
expect(page).not_to have_link("All")
expect(page).to have_link("Confirmed")
visit admin_hidden_comments_path(filter: "with_confirmed_hide")
expect(page).to have_link("Pending")
expect(page).to have_link("All")
expect(page).not_to have_link("Confirmed")
end
scenario "Filtering comments" do
create(:comment, :hidden, body: "Unconfirmed comment")
create(:comment, :hidden, :with_confirmed_hide, body: "Confirmed comment")
visit admin_hidden_comments_path(filter: "all")
expect(page).to have_content("Unconfirmed comment")
expect(page).to have_content("Confirmed comment")
visit admin_hidden_comments_path(filter: "with_confirmed_hide")
expect(page).not_to have_content("Unconfirmed comment")
expect(page).to have_content("Confirmed comment")
end
scenario "Action links remember the pagination setting and the filter" do
allow(Comment).to receive(:default_per_page).and_return(2)
4.times { create(:comment, :hidden, :with_confirmed_hide) }
visit admin_hidden_comments_path(filter: "with_confirmed_hide", page: 2)
accept_confirm("Are you sure? Restore") { click_button "Restore", match: :first, exact: true }
expect(page).to have_current_path(/filter=with_confirmed_hide/)
expect(page).to have_current_path(/page=2/)
end
end