c025fef50b
Since targets didn't have a title but only a long description, every form allowing to select targets was pretty much unusable: we either displayed just the code or the whole description. Now, with a concise title, it's easier to find and select the desired target. The titles have been copied from The Global Goals page [1]. Note we're using the `short_title` I18n key for the `title` method and the `long_title` I18n key for the `long_title` method. We can't use `title` as I18n key instead of `short_title` because it would affect existing translations. [1] https://www.globalgoals.org/
140 lines
4.4 KiB
Ruby
140 lines
4.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe SDG::Target do
|
|
it "is valid" do
|
|
expect(build(:sdg_target, code: "1.Z", goal: SDG::Goal[1])).to be_valid
|
|
end
|
|
|
|
it "is not valid without a code" do
|
|
expect(build(:sdg_target, code: nil)).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a goal" do
|
|
target = build(:sdg_target, goal: nil)
|
|
|
|
expect(target).not_to be_valid
|
|
end
|
|
|
|
it "is not valid if code is not unique" do
|
|
goal = SDG::Goal[1]
|
|
create(:sdg_target, code: "1.Z", goal: goal)
|
|
target = build(:sdg_target, code: "1.Z", goal: goal)
|
|
|
|
expect(target).not_to be_valid
|
|
expect(target.errors.full_messages).to include "Code has already been taken"
|
|
end
|
|
|
|
describe "#long_title" do
|
|
it "returns the official title in the desired language" do
|
|
target = SDG::Target["1.1"]
|
|
|
|
expect(target.long_title).to start_with "By 2030, eradicate extreme poverty"
|
|
|
|
I18n.with_locale(:es) do
|
|
expect(target.long_title).to start_with "Para 2030, erradicar la pobreza extrema"
|
|
end
|
|
|
|
target = SDG::Target["17.11"]
|
|
|
|
expect(target.long_title).to start_with "Significantly increase the exports of developing countries"
|
|
|
|
I18n.with_locale(:es) do
|
|
expect(target.long_title).to start_with "Aumentar significativamente las exportaciones de los países"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#title" do
|
|
let(:target) { SDG::Target["1.1"] }
|
|
|
|
it "returns the abbreviated title" do
|
|
expect(target.title).to eq "Eradicate Extreme Poverty"
|
|
end
|
|
|
|
context "translation unavailable" do
|
|
after { I18n.backend.reload! }
|
|
|
|
it "returns the official title when the abbreviated title isn't available" do
|
|
keys = { goals: { goal_1: { targets: { target_1_1: { short_title: nil }}}}}
|
|
|
|
I18n.backend.store_translations(:en, { sdg: keys })
|
|
|
|
expect(target.title).to start_with "By 2030, eradicate extreme poverty"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#code_and_title" do
|
|
it "returns the code and the abbreviated title" do
|
|
target = SDG::Target["8.A"]
|
|
|
|
expect(target.code_and_title).to eq "8.A. Increase Aid for Trade Support"
|
|
end
|
|
end
|
|
|
|
describe "#<=>" do
|
|
let(:goal) { build(:sdg_goal, code: 10) }
|
|
let(:target) { build(:sdg_target, code: "10.19", goal: goal) }
|
|
|
|
it "compares using the goal first" do
|
|
lesser_target = build(:sdg_target, code: "2.14", goal: build(:sdg_goal, code: 2))
|
|
greater_target = build(:sdg_target, code: "11.1", goal: build(:sdg_goal, code: 11))
|
|
|
|
expect(target).to be > lesser_target
|
|
expect(target).to be < greater_target
|
|
end
|
|
|
|
it "compares using the target code when the goal is the same" do
|
|
lesser_target = build(:sdg_target, code: "10.2", goal: goal)
|
|
greater_target = build(:sdg_target, code: "10.A", goal: goal)
|
|
|
|
expect(target).to be > lesser_target
|
|
expect(target).to be < greater_target
|
|
end
|
|
|
|
context "comparing with a local target" do
|
|
it "compares using the goal first" do
|
|
lesser_local_target = build(:sdg_local_target, code: "2.1.1")
|
|
greater_local_target = build(:sdg_local_target, code: "11.1.2")
|
|
|
|
expect(target).to be > lesser_local_target
|
|
expect(target).to be < greater_local_target
|
|
end
|
|
|
|
it "compares using the target when the goal is the same" do
|
|
lesser_target = build(:sdg_target, code: "10.2", goal: goal)
|
|
greater_target = build(:sdg_target, code: "10.A", goal: goal)
|
|
lesser_local_target = build(:sdg_local_target, code: "10.2.25", target: lesser_target)
|
|
greater_local_target = build(:sdg_local_target, code: "10.A.1", target: greater_target)
|
|
|
|
expect(target).to be > lesser_local_target
|
|
expect(target).to be < greater_local_target
|
|
end
|
|
|
|
it "is smaller than a local target belonging to it" do
|
|
local_target = build(:sdg_local_target, target: target, code: "10.19.1")
|
|
|
|
expect(target).to be < local_target
|
|
end
|
|
end
|
|
|
|
it "can be compared against goals" do
|
|
lesser_goal = build(:sdg_goal, code: "9")
|
|
greater_goal = build(:sdg_goal, code: "11")
|
|
|
|
expect(target).to be > lesser_goal
|
|
expect(target).to be < greater_goal
|
|
end
|
|
end
|
|
|
|
describe ".[]" do
|
|
it "finds existing targets by code" do
|
|
expect(SDG::Target["1.1"].code).to eq "1.1"
|
|
end
|
|
|
|
it "raises an exception for non-existing codes" do
|
|
expect { SDG::Target["Z.j3"] }.to raise_exception ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
end
|