f63be041c1
After a `visit`, we were checking for content or filling in fields that
were already there before the `visit`, so we weren't 100% sure that the
request had finished before the test continued.
In the case of the verification tests, we were clicking the submit
buttons over and over without and then checking or interacting with
elements that were already there. Even though the button was disabled
between requests, meaning there wouldn't be simultaneous requests, it
was possible to interact with a form field before waiting for the
request to finish.
Some of these tests have recently failed on our CI, and it might be
because of that:
```
1) Admin budgets Edit Changing name for current locale will update the
slug if budget is in draft phase
Failure/Error: raise ex, cause: cause
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
1) Budgets creation wizard Creation of a multiple-headings budget by
steps
Failure/Error: expect(page).to have_content "Heading created
successfully!"
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
1) Custom information texts Show custom texts instead of default ones
Failure/Error: raise ex, cause: cause
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
1) Users Regular authentication Sign in Avoid username-email collisions
Failure/Error: raise ex, cause: cause
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
2) Verify Letter Code verification 6 tries allowed
Failure/Error: raise ex, cause: cause
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
2) Valuation budget investments Valuate Finish valuation
Failure/Error: raise ex, cause: cause
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
1) Users Delete a level 2 user account from document verification page
Failure/Error: raise ex, cause: cause
Selenium::WebDriver::Error::UnknownError:
unknown error: unhandled inspector error: {"code":-32000,
"message":"Node with given id does not belong to the document"}
(Session info: chrome=134.0.6998.35)
```
262 lines
8.9 KiB
Ruby
262 lines
8.9 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Executions" do
|
|
let(:budget) { create(:budget, :finished) }
|
|
let(:group) { create(:budget_group, budget: budget) }
|
|
let(:heading) { create(:budget_heading, group: group) }
|
|
|
|
let!(:investment1) { create(:budget_investment, :winner, heading: heading) }
|
|
let!(:investment2) { create(:budget_investment, :winner, heading: heading) }
|
|
let!(:investment4) { create(:budget_investment, :winner, heading: heading) }
|
|
let!(:investment3) { create(:budget_investment, :incompatible, heading: heading) }
|
|
|
|
scenario "finds budget by slug" do
|
|
budget.update!(slug: "budget_slug")
|
|
|
|
visit budget_executions_path("budget_slug")
|
|
within(".budgets-stats") { expect(page).to have_content budget.name }
|
|
end
|
|
|
|
scenario "finds budget by id" do
|
|
visit budget_executions_path(budget.id)
|
|
|
|
within(".budgets-stats") { expect(page).to have_content budget.name }
|
|
end
|
|
|
|
scenario "only displays investments with milestones" do
|
|
create(:milestone, milestoneable: investment1)
|
|
|
|
visit budget_path(budget)
|
|
|
|
expect(page).not_to have_content(investment1.title)
|
|
|
|
click_link "See results"
|
|
|
|
expect(page).to have_content(investment1.title)
|
|
expect(page).to have_content(investment2.title)
|
|
expect(page).to have_content(investment4.title)
|
|
|
|
click_link "Milestones"
|
|
|
|
expect(page).not_to have_content(investment2.title)
|
|
expect(page).not_to have_content(investment3.title)
|
|
expect(page).not_to have_content(investment4.title)
|
|
expect(page).to have_content(investment1.title)
|
|
end
|
|
|
|
scenario "Do not display headings with no winning investments for selected status" do
|
|
create(:milestone, milestoneable: investment1)
|
|
|
|
empty_group = create(:budget_group, budget: budget)
|
|
empty_heading = create(:budget_heading, group: empty_group, price: 1000)
|
|
|
|
visit budget_path(budget)
|
|
click_link "See results"
|
|
|
|
expect(page).to have_content(heading.name)
|
|
expect(page).to have_content(empty_heading.name)
|
|
|
|
click_link "Milestones"
|
|
|
|
expect(page).to have_content(heading.name)
|
|
expect(page).not_to have_content(empty_heading.name)
|
|
end
|
|
|
|
scenario "Show message when there are no winning investments with the selected status" do
|
|
create(:milestone, milestoneable: investment1)
|
|
create(:milestone_status, name: "Executed")
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).not_to have_content("No winner investments in this state")
|
|
|
|
select "Executed (0)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content("No winner investments in this state")
|
|
end
|
|
|
|
scenario "Back link redirects to budget page" do
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_link("Go back", href: budget_path(budget))
|
|
end
|
|
|
|
context "Images" do
|
|
scenario "renders default image if no milestone nor investment images are available" do
|
|
create(:milestone, milestoneable: investment4)
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_content investment4.title
|
|
expect(page).to have_css "img[alt='#{investment4.title}']"
|
|
end
|
|
end
|
|
|
|
context "Filters" do
|
|
let!(:status1) { create(:milestone_status, name: "Studying the project") }
|
|
let!(:status2) { create(:milestone_status, name: "Bidding") }
|
|
|
|
scenario "Filters select with counter are shown" do
|
|
create(:milestone, milestoneable: investment1,
|
|
publication_date: Date.yesterday,
|
|
status: status1)
|
|
|
|
create(:milestone, milestoneable: investment2,
|
|
publication_date: Date.yesterday,
|
|
status: status2)
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_content("All (2)")
|
|
expect(page).to have_content("#{status1.name} (1)")
|
|
expect(page).to have_content("#{status2.name} (1)")
|
|
end
|
|
|
|
scenario "by milestone status" do
|
|
create(:milestone, milestoneable: investment1, status: status1)
|
|
create(:milestone, milestoneable: investment2, status: status2)
|
|
create(:milestone_status, name: I18n.t("seeds.budgets.statuses.executing_project"))
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_content(investment1.title)
|
|
expect(page).to have_content(investment2.title)
|
|
|
|
select "Studying the project (1)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).not_to have_content(investment2.title)
|
|
expect(page).to have_content(investment1.title)
|
|
|
|
select "Bidding (1)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content(investment2.title)
|
|
expect(page).not_to have_content(investment1.title)
|
|
|
|
select "Executing the project (0)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).not_to have_content(investment2.title)
|
|
expect(page).not_to have_content(investment1.title)
|
|
end
|
|
|
|
scenario "are based on latest milestone status" do
|
|
create(:milestone, milestoneable: investment1,
|
|
publication_date: 1.month.ago,
|
|
status: status1)
|
|
|
|
create(:milestone, milestoneable: investment1,
|
|
publication_date: Date.yesterday,
|
|
status: status2)
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_content investment1.title
|
|
|
|
select "Studying the project (0)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).not_to have_content investment1.title
|
|
|
|
select "Bidding (1)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content investment1.title
|
|
end
|
|
|
|
scenario "milestones with future dates are not shown" do
|
|
create(:milestone, milestoneable: investment1,
|
|
publication_date: Date.yesterday,
|
|
status: status1)
|
|
|
|
create(:milestone, milestoneable: investment1,
|
|
publication_date: Date.tomorrow,
|
|
status: status2)
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_content investment1.title
|
|
|
|
select "Bidding (0)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).not_to have_content investment1.title
|
|
|
|
select "Studying the project (1)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content investment1.title
|
|
end
|
|
|
|
scenario "by milestone tag, only display tags for winner investments" do
|
|
create(:milestone, milestoneable: investment1, status: status1)
|
|
create(:milestone, milestoneable: investment2, status: status2)
|
|
create(:milestone, milestoneable: investment3, status: status2)
|
|
investment1.milestone_tag_list.add("tag1", "tag2")
|
|
investment1.save!
|
|
investment2.milestone_tag_list.add("tag2")
|
|
investment2.save!
|
|
investment3.milestone_tag_list.add("tag2")
|
|
investment3.save!
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_content(investment1.title)
|
|
expect(page).to have_content(investment2.title)
|
|
|
|
select "tag2 (2)", from: "Milestone tag"
|
|
select "Studying the project (1)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).not_to have_content(investment2.title)
|
|
expect(page).to have_content(investment1.title)
|
|
|
|
select "Bidding (1)", from: "Project's current state"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content(investment2.title)
|
|
expect(page).not_to have_content(investment1.title)
|
|
|
|
select "tag1 (1)", from: "Milestone tag"
|
|
click_button "Filter"
|
|
|
|
expect(page).not_to have_content(investment2.title)
|
|
expect(page).not_to have_content(investment1.title)
|
|
|
|
select "All (2)", from: "Milestone tag"
|
|
click_button "Filter"
|
|
|
|
expect(page).to have_content(investment2.title)
|
|
expect(page).not_to have_content(investment1.title)
|
|
end
|
|
end
|
|
|
|
context "Heading Order" do
|
|
scenario "Non-city headings are displayed in alphabetical order" do
|
|
heading.destroy!
|
|
z_heading = create(:budget_heading, :with_investment_with_milestone, group: group, name: "Zzz")
|
|
a_heading = create(:budget_heading, :with_investment_with_milestone, group: group, name: "Aaa")
|
|
m_heading = create(:budget_heading, :with_investment_with_milestone, group: group, name: "Mmm")
|
|
|
|
visit budget_executions_path(budget)
|
|
|
|
expect(page).to have_css(".budget-executions-investment", count: 3)
|
|
expect(a_heading.name).to appear_before(m_heading.name)
|
|
expect(m_heading.name).to appear_before(z_heading.name)
|
|
end
|
|
end
|
|
|
|
context "No milestones" do
|
|
scenario "Milestone not yet published" do
|
|
status = create(:milestone_status)
|
|
create(:milestone, milestoneable: investment1, status: status, publication_date: Date.tomorrow)
|
|
|
|
visit budget_executions_path(budget, status: status.id)
|
|
|
|
expect(page).to have_content("No winner investments in this state")
|
|
end
|
|
end
|
|
end
|