db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
142 lines
4.6 KiB
Ruby
142 lines
4.6 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Poll::Officer do
|
|
describe "#name" do
|
|
let(:officer) { create(:poll_officer) }
|
|
|
|
it "returns user name if user is not deleted" do
|
|
expect(officer.name).to eq officer.user.name
|
|
end
|
|
|
|
it "returns 'User deleted' if user is deleted" do
|
|
officer.user.destroy!
|
|
|
|
expect(officer.reload.name).to eq "User deleted"
|
|
end
|
|
end
|
|
|
|
describe "#email" do
|
|
let(:officer) { create(:poll_officer) }
|
|
|
|
it "returns user email if user is not deleted" do
|
|
expect(officer.email).to eq officer.user.email
|
|
end
|
|
|
|
it "returns 'Email deleted' if user is deleted" do
|
|
officer.user.destroy!
|
|
|
|
expect(officer.reload.email).to eq "Email deleted"
|
|
end
|
|
end
|
|
|
|
describe "#voting_days_assigned_polls" do
|
|
it "returns all polls with this officer assigned during voting days" do
|
|
officer = create(:poll_officer)
|
|
|
|
poll_1 = create(:poll)
|
|
poll_2 = create(:poll)
|
|
poll_3 = create(:poll)
|
|
|
|
create(:poll_officer_assignment, poll: poll_1, officer: officer, date: poll_1.starts_at)
|
|
create(:poll_officer_assignment, poll: poll_1, officer: officer, date: poll_1.ends_at)
|
|
create(:poll_officer_assignment, poll: poll_2, officer: officer)
|
|
create(:poll_officer_assignment, poll: poll_3, officer: officer, final: true)
|
|
|
|
assigned_polls = officer.voting_days_assigned_polls
|
|
|
|
expect(assigned_polls).to match_array [poll_1, poll_2]
|
|
end
|
|
|
|
it "does not return polls with this officer assigned for final recount/results" do
|
|
officer = create(:poll_officer)
|
|
|
|
poll_1 = create(:poll)
|
|
poll_2 = create(:poll)
|
|
|
|
create(:poll_officer_assignment, poll: poll_1, officer: officer, date: poll_1.starts_at)
|
|
create(:poll_officer_assignment, poll: poll_2, officer: officer, final: true)
|
|
|
|
assigned_polls = officer.voting_days_assigned_polls
|
|
|
|
expect(assigned_polls).to eq [poll_1]
|
|
end
|
|
|
|
it "returns polls ordered by end date (desc)" do
|
|
officer = create(:poll_officer)
|
|
|
|
poll_1 = create(:poll, ends_at: 1.day.ago, officers: [officer])
|
|
poll_2 = create(:poll, ends_at: 10.days.from_now, officers: [officer])
|
|
poll_3 = create(:poll, ends_at: 10.days.ago, officers: [officer])
|
|
|
|
assigned_polls = officer.voting_days_assigned_polls
|
|
|
|
expect(assigned_polls).to eq [poll_2, poll_1, poll_3]
|
|
end
|
|
end
|
|
|
|
describe "#final_days_assigned_polls" do
|
|
it "returns all polls with this officer assigned for final recount/results" do
|
|
officer = create(:poll_officer)
|
|
|
|
poll_1 = create(:poll)
|
|
poll_2 = create(:poll)
|
|
poll_3 = create(:poll)
|
|
|
|
create(:poll_officer_assignment, :final, poll: poll_1, officer: officer, date: poll_1.starts_at)
|
|
create(:poll_officer_assignment, :final, poll: poll_1, officer: officer, date: poll_1.ends_at)
|
|
create(:poll_officer_assignment, :final, poll: poll_2, officer: officer)
|
|
create(:poll_officer_assignment, poll: poll_3, officer: officer)
|
|
|
|
assigned_polls = officer.final_days_assigned_polls
|
|
|
|
expect(assigned_polls).to match_array [poll_1, poll_2]
|
|
end
|
|
|
|
it "does not return polls with this officer assigned for voting days" do
|
|
officer = create(:poll_officer)
|
|
|
|
poll_1 = create(:poll)
|
|
poll_2 = create(:poll)
|
|
|
|
create(:poll_officer_assignment, poll: poll_1, officer: officer, date: poll_1.starts_at)
|
|
create(:poll_officer_assignment, poll: poll_2, officer: officer, final: true)
|
|
|
|
assigned_polls = officer.final_days_assigned_polls
|
|
|
|
expect(assigned_polls).to eq [poll_2]
|
|
end
|
|
|
|
it "returns polls ordered by end date (desc)" do
|
|
officer = create(:poll_officer)
|
|
|
|
poll_1 = create(:poll, ends_at: 1.day.ago)
|
|
poll_2 = create(:poll, ends_at: 10.days.from_now)
|
|
poll_3 = create(:poll, ends_at: 10.days.ago)
|
|
|
|
[poll_1, poll_2, poll_3].each do |poll|
|
|
create(:poll_officer_assignment, :final, officer: officer, poll: poll)
|
|
end
|
|
|
|
assigned_polls = officer.final_days_assigned_polls
|
|
|
|
expect(assigned_polls).to eq [poll_2, poll_1, poll_3]
|
|
end
|
|
end
|
|
|
|
describe "todays_booths", :application_zone_west_of_system_zone do
|
|
let(:officer) { create(:poll_officer) }
|
|
|
|
it "returns today's booths" do
|
|
todays_assignment = create(:poll_officer_assignment, date: Date.current, officer: officer)
|
|
expect(officer.todays_booths).to eq [todays_assignment.booth]
|
|
end
|
|
|
|
it "does not return booths for different dates" do
|
|
create(:poll_officer_assignment, date: Date.yesterday, officer: officer)
|
|
create(:poll_officer_assignment, date: Date.tomorrow, officer: officer)
|
|
|
|
expect(officer.todays_booths).to be_empty
|
|
end
|
|
end
|
|
end
|