We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
20 lines
331 B
Ruby
20 lines
331 B
Ruby
class Legislation::Process::Phase
|
|
def initialize(start_date, end_date, enabled)
|
|
@start_date = start_date
|
|
@end_date = end_date
|
|
@enabled = enabled
|
|
end
|
|
|
|
def enabled?
|
|
@enabled
|
|
end
|
|
|
|
def started?
|
|
enabled? && Date.current >= @start_date
|
|
end
|
|
|
|
def open?
|
|
started? && Date.current <= @end_date
|
|
end
|
|
end
|