ff93f5a591
In the past, we couldn't use `polymorphic_path` in many places. For instance, `polymorphic_path(budget, investment)` would return `budget_budget_investment_path`, while in our routes we had defined `budget_investment_path`. With the `resolve` method, introduced in Rails 5.1, we can use symbols to define we want it to use `investment` instead of `budget_investment`. It also works with nested resources, so now we can write `polymorphic_path(investment)`. This makes the code for `resource_hierarchy_for` almost impossible to understand. I reached this result after having a look at the internals of the `resolve` method in order to get its results and then remove the symbols we include. Note using this method will not make admin routes compatible with `polymorphic_path`. Quoting from the Rails documentation: > This custom behavior only applies to simple polymorphic URLs where a > single model instance is passed and not more complicated forms, e.g: > [example showing admin routes won't work] Also note that now the `admin_polymorphic_path` method will not work for every model due to inconsistencies in our admin routes. For instance, we define `groups` and `budget_investments`; we should either use the `budget_` prefix in all places or remove it everywhere. Right now the code only works for items with the prefix; it isn't a big deal because we never call it with an item without the prefix. Finally, for unknown reasons some routing tests fail if we use `polymorphic_path`, so we need to redefine that method in those tests and force the `only_path: true` option.
86 lines
2.4 KiB
Ruby
86 lines
2.4 KiB
Ruby
module CommentsHelper
|
|
def comment_tree_title_text(commentable)
|
|
if commentable.class == Legislation::Question
|
|
t("legislation.questions.comments.comments_title")
|
|
else
|
|
t("comments_helper.comments_title")
|
|
end
|
|
end
|
|
|
|
def leave_comment_text(commentable)
|
|
if commentable.class == Legislation::Question
|
|
t("legislation.questions.comments.form.leave_comment")
|
|
else
|
|
t("comments.form.leave_comment")
|
|
end
|
|
end
|
|
|
|
def comment_link_text(parent_id)
|
|
parent_id.present? ? t("comments_helper.reply_link") : t("comments_helper.comment_link")
|
|
end
|
|
|
|
def comment_button_text(parent_id, commentable)
|
|
if commentable.class == Legislation::Question
|
|
parent_id.present? ? t("comments_helper.reply_button") : t("legislation.questions.comments.comment_button")
|
|
else
|
|
parent_id.present? ? t("comments_helper.reply_button") : t("comments_helper.comment_button")
|
|
end
|
|
end
|
|
|
|
def parent_or_commentable_dom_id(parent_id, commentable)
|
|
parent_id.blank? ? dom_id(commentable) : "comment_#{parent_id}"
|
|
end
|
|
|
|
def child_comments_of(parent)
|
|
if @comment_tree.present?
|
|
@comment_tree.ordered_children_of(parent)
|
|
else
|
|
parent.children
|
|
end
|
|
end
|
|
|
|
def commentable_path(comment)
|
|
polymorphic_path(comment.commentable)
|
|
end
|
|
|
|
def user_level_class(comment)
|
|
if comment.as_administrator?
|
|
"is-admin"
|
|
elsif comment.as_moderator?
|
|
"is-moderator"
|
|
elsif comment.user.official?
|
|
"level-#{comment.user.official_level}"
|
|
else
|
|
"" # Default no special user class
|
|
end
|
|
end
|
|
|
|
def comment_author_class(comment, author_id)
|
|
if comment.user_id == author_id
|
|
"is-author"
|
|
else
|
|
"" # Default not author class
|
|
end
|
|
end
|
|
|
|
def require_verified_resident_for_commentable?(commentable, current_user)
|
|
return false if current_user.administrator? || current_user.moderator?
|
|
|
|
commentable.respond_to?(:comments_for_verified_residents_only?) &&
|
|
commentable.comments_for_verified_residents_only? &&
|
|
!current_user.residence_verified?
|
|
end
|
|
|
|
def comments_closed_for_commentable?(commentable)
|
|
commentable.respond_to?(:comments_closed?) && commentable.comments_closed?
|
|
end
|
|
|
|
def comments_closed_text(commentable)
|
|
if commentable.class == Legislation::Question
|
|
t("legislation.questions.comments.comments_closed")
|
|
else
|
|
t("comments.comments_closed")
|
|
end
|
|
end
|
|
end
|