a3a44f527b
The "on_budget_investments" scope in Activity has never been used
anywhere in the codebase. It was introduced in commit d9d38482b3
("extends Activity to include Investment valuations") but no references
were ever added.
Instead of removing it, we make use of the scope by adding the missing
"Budget investments" filter to the admin Activity section. This aligns
it with the rest of the activity filters and gives the scope the purpose
it was originally intended for.
453 lines
14 KiB
Ruby
453 lines
14 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin activity" do
|
|
let(:admin) { create(:administrator) }
|
|
|
|
before do
|
|
login_as(admin.user)
|
|
end
|
|
|
|
context "Proposals" do
|
|
scenario "Shows moderation activity on proposals" do
|
|
proposal = create(:proposal, description: "<p>Description with html tag</p>")
|
|
|
|
visit proposal_path(proposal)
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
accept_confirm("Are you sure? Hide \"#{proposal.title}\"") { click_button "Hide" }
|
|
end
|
|
expect(page).to have_css("#proposal_#{proposal.id}.faded")
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(proposal.title)
|
|
expect(page).to have_content("Hidden")
|
|
expect(page).to have_content(admin.user.username)
|
|
expect(page).to have_css("p", exact_text: "Description with html tag")
|
|
end
|
|
end
|
|
|
|
scenario "Shows moderation activity from moderation screen" do
|
|
proposal1 = create(:proposal)
|
|
proposal2 = create(:proposal)
|
|
proposal3 = create(:proposal)
|
|
|
|
visit moderation_proposals_path(filter: "all")
|
|
|
|
within("#proposal_#{proposal1.id}") do
|
|
check "proposal_#{proposal1.id}_check"
|
|
end
|
|
|
|
within("#proposal_#{proposal3.id}") do
|
|
check "proposal_#{proposal3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Hide proposals") { click_button "Hide proposals" }
|
|
|
|
expect(page).not_to have_content(proposal1.title)
|
|
|
|
visit admin_activity_path
|
|
|
|
expect(page).to have_content(proposal1.title)
|
|
expect(page).not_to have_content(proposal2.title)
|
|
expect(page).to have_content(proposal3.title)
|
|
end
|
|
|
|
scenario "Shows admin restores" do
|
|
proposal = create(:proposal, :hidden)
|
|
|
|
visit admin_hidden_proposals_path
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
accept_confirm("Are you sure? Restore") { click_button "Restore" }
|
|
end
|
|
|
|
expect(page).to have_content "There are no hidden proposals"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(proposal.title)
|
|
expect(page).to have_content("Restored")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Debates" do
|
|
scenario "Shows moderation activity on debates" do
|
|
debate = create(:debate)
|
|
|
|
visit debate_path(debate)
|
|
|
|
within("#debate_#{debate.id}") do
|
|
accept_confirm("Are you sure? Hide \"#{debate.title}\"") { click_button "Hide" }
|
|
end
|
|
expect(page).to have_css("#debate_#{debate.id}.faded")
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(debate.title)
|
|
expect(page).to have_content("Hidden")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
|
|
scenario "Shows moderation activity from moderation screen" do
|
|
debate1 = create(:debate)
|
|
debate2 = create(:debate)
|
|
debate3 = create(:debate)
|
|
|
|
visit moderation_debates_path(filter: "all")
|
|
|
|
within("#debate_#{debate1.id}") do
|
|
check "debate_#{debate1.id}_check"
|
|
end
|
|
|
|
within("#debate_#{debate3.id}") do
|
|
check "debate_#{debate3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Hide debates") { click_button "Hide debates" }
|
|
|
|
expect(page).not_to have_content(debate1.title)
|
|
|
|
visit admin_activity_path
|
|
|
|
expect(page).to have_content(debate1.title)
|
|
expect(page).not_to have_content(debate2.title)
|
|
expect(page).to have_content(debate3.title)
|
|
end
|
|
|
|
scenario "Shows admin restores" do
|
|
debate = create(:debate, :hidden)
|
|
|
|
visit admin_hidden_debates_path
|
|
|
|
within("#debate_#{debate.id}") do
|
|
accept_confirm("Are you sure? Restore") { click_button "Restore" }
|
|
end
|
|
|
|
expect(page).to have_content "There are no hidden debates"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(debate.title)
|
|
expect(page).to have_content("Restored")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Comments" do
|
|
scenario "Shows moderation activity on comments" do
|
|
debate = create(:debate)
|
|
comment = create(:comment, commentable: debate)
|
|
|
|
visit debate_path(debate)
|
|
|
|
within("#comment_#{comment.id}") do
|
|
accept_confirm("Are you sure? Hide \"#{comment.body}\"") { click_button "Hide" }
|
|
expect(page).to have_css(".faded")
|
|
end
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(comment.body)
|
|
expect(page).to have_content("Hidden")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
|
|
scenario "Shows moderation activity from moderation screen" do
|
|
comment1 = create(:comment, body: "SPAM")
|
|
comment2 = create(:comment)
|
|
comment3 = create(:comment, body: "Offensive!")
|
|
|
|
visit moderation_comments_path(filter: "all")
|
|
|
|
within("#comment_#{comment1.id}") do
|
|
check "comment_#{comment1.id}_check"
|
|
end
|
|
|
|
within("#comment_#{comment3.id}") do
|
|
check "comment_#{comment3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Hide comments") { click_button "Hide comments" }
|
|
|
|
expect(page).not_to have_content(comment1.body)
|
|
|
|
visit admin_activity_path
|
|
|
|
expect(page).to have_content(comment1.body)
|
|
expect(page).not_to have_content(comment2.body)
|
|
expect(page).to have_content(comment3.body)
|
|
end
|
|
|
|
scenario "Shows admin restores" do
|
|
comment = create(:comment, :hidden)
|
|
|
|
visit admin_hidden_comments_path
|
|
|
|
within("#comment_#{comment.id}") do
|
|
accept_confirm("Are you sure? Restore") { click_button "Restore" }
|
|
end
|
|
|
|
expect(page).to have_content "There are no hidden comments"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(comment.body)
|
|
expect(page).to have_content("Restored")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "User" do
|
|
scenario "Shows moderation activity on users" do
|
|
proposal = create(:proposal, author: create(:user, username: "Sam"))
|
|
|
|
visit proposal_path(proposal)
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
accept_confirm("Are you sure? This will hide the user \"Sam\" and all their contents.") do
|
|
click_button "Block author"
|
|
end
|
|
|
|
expect(page).to have_current_path(proposals_path)
|
|
end
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content("Blocked")
|
|
expect(page).to have_content(proposal.author.username)
|
|
expect(page).to have_content(proposal.author.email)
|
|
expect(page).to have_content(admin.user.username)
|
|
expect(page).not_to have_content(proposal.title)
|
|
end
|
|
end
|
|
|
|
scenario "Shows moderation activity from moderation screen" do
|
|
user = create(:user)
|
|
|
|
visit moderation_users_path(search: user.username)
|
|
|
|
within("#moderation_users") do
|
|
accept_confirm { click_button "Block" }
|
|
end
|
|
|
|
expect(page).to have_content "The user has been blocked"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(user.username)
|
|
expect(page).to have_content(user.email)
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
|
|
scenario "Shows moderation activity from proposals moderation screen" do
|
|
proposal1 = create(:proposal)
|
|
proposal2 = create(:proposal)
|
|
proposal3 = create(:proposal)
|
|
|
|
visit moderation_proposals_path(filter: "all")
|
|
|
|
within("#proposal_#{proposal1.id}") do
|
|
check "proposal_#{proposal1.id}_check"
|
|
end
|
|
|
|
within("#proposal_#{proposal3.id}") do
|
|
check "proposal_#{proposal3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Block authors") { click_button "Block authors" }
|
|
|
|
expect(page).not_to have_content(proposal1.author.username)
|
|
|
|
visit admin_activity_path
|
|
|
|
expect(page).to have_content(proposal1.author.username)
|
|
expect(page).to have_content(proposal1.author.email)
|
|
expect(page).to have_content(proposal3.author.username)
|
|
expect(page).to have_content(proposal3.author.email)
|
|
expect(page).not_to have_content(proposal2.author.username)
|
|
end
|
|
|
|
scenario "Shows moderation activity from debates moderation screen" do
|
|
debate1 = create(:debate)
|
|
debate2 = create(:debate)
|
|
debate3 = create(:debate)
|
|
|
|
visit moderation_debates_path(filter: "all")
|
|
|
|
within("#debate_#{debate1.id}") do
|
|
check "debate_#{debate1.id}_check"
|
|
end
|
|
|
|
within("#debate_#{debate3.id}") do
|
|
check "debate_#{debate3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Block authors") { click_button "Block authors" }
|
|
|
|
expect(page).not_to have_content(debate1.author.username)
|
|
|
|
visit admin_activity_path
|
|
|
|
expect(page).to have_content(debate1.author.username)
|
|
expect(page).to have_content(debate1.author.email)
|
|
expect(page).to have_content(debate3.author.username)
|
|
expect(page).to have_content(debate3.author.email)
|
|
expect(page).not_to have_content(debate2.author.username)
|
|
end
|
|
|
|
scenario "Shows moderation activity from comments moderation screen" do
|
|
comment1 = create(:comment, body: "SPAM")
|
|
comment2 = create(:comment)
|
|
comment3 = create(:comment, body: "Offensive!")
|
|
|
|
visit moderation_comments_path(filter: "all")
|
|
|
|
within("#comment_#{comment1.id}") do
|
|
check "comment_#{comment1.id}_check"
|
|
end
|
|
|
|
within("#comment_#{comment3.id}") do
|
|
check "comment_#{comment3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Block authors") { click_button "Block authors" }
|
|
|
|
expect(page).not_to have_content comment1.author.username
|
|
|
|
visit admin_activity_path
|
|
|
|
expect(page).to have_content(comment1.author.username)
|
|
expect(page).to have_content(comment1.author.email)
|
|
expect(page).to have_content(comment3.author.username)
|
|
expect(page).to have_content(comment3.author.email)
|
|
expect(page).not_to have_content(comment2.author.username)
|
|
end
|
|
|
|
scenario "Shows admin restores" do
|
|
user = create(:user, :hidden)
|
|
|
|
visit admin_hidden_users_path
|
|
|
|
within("#user_#{user.id}") do
|
|
accept_confirm("Are you sure? Restore") { click_button "Restore" }
|
|
end
|
|
|
|
expect(page).to have_content "There are no hidden users"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(user.username)
|
|
expect(page).to have_content(user.email)
|
|
expect(page).to have_content("Restored")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "System emails" do
|
|
scenario "Shows moderation activity on system emails" do
|
|
proposal = create(:proposal, title: "Proposal A")
|
|
proposal_notification = create(:proposal_notification, proposal: proposal,
|
|
title: "Proposal A Title",
|
|
body: "Proposal A Notification Body")
|
|
proposal_notification.moderate_system_email(admin.user)
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(proposal_notification.title)
|
|
expect(page).to have_content("Hidden")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Budget investments" do
|
|
scenario "Shows moderation activity on budget investments" do
|
|
investment = create(:budget_investment, description: "<p>Investment description</p>")
|
|
|
|
visit budget_investment_path(investment.budget, investment)
|
|
|
|
within "#budget_investment_#{investment.id}" do
|
|
accept_confirm("Are you sure? Hide") { click_button "Hide" }
|
|
end
|
|
|
|
expect(page).to have_css "#budget_investment_#{investment.id}.faded"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(investment.title)
|
|
expect(page).to have_content("Hidden")
|
|
expect(page).to have_content(admin.user.username)
|
|
expect(page).to have_css("p", exact_text: "Investment description")
|
|
end
|
|
end
|
|
|
|
scenario "Shows moderation activity from moderation screen" do
|
|
investment1 = create(:budget_investment)
|
|
investment2 = create(:budget_investment)
|
|
investment3 = create(:budget_investment)
|
|
|
|
visit moderation_budget_investments_path(filter: "all")
|
|
|
|
within "#investment_#{investment1.id}" do
|
|
check "budget_investment_#{investment1.id}_check"
|
|
end
|
|
|
|
within "#investment_#{investment3.id}" do
|
|
check "budget_investment_#{investment3.id}_check"
|
|
end
|
|
|
|
accept_confirm("Are you sure? Hide budget investments") do
|
|
click_button "Hide budget investments"
|
|
end
|
|
|
|
expect(page).not_to have_content(investment1.title)
|
|
|
|
visit admin_activity_path(filter: "on_budget_investments")
|
|
|
|
expect(page).to have_content(investment1.title)
|
|
expect(page).not_to have_content(investment2.title)
|
|
expect(page).to have_content(investment3.title)
|
|
end
|
|
|
|
scenario "Shows admin restores" do
|
|
investment = create(:budget_investment, :hidden)
|
|
|
|
visit admin_hidden_budget_investments_path
|
|
|
|
within "#budget_investment_#{investment.id}" do
|
|
accept_confirm("Are you sure? Restore") { click_button "Restore" }
|
|
end
|
|
|
|
expect(page).to have_content "There are no hidden budget investments"
|
|
|
|
visit admin_activity_path
|
|
|
|
within first("tbody tr") do
|
|
expect(page).to have_content(investment.title)
|
|
expect(page).to have_content("Restored")
|
|
expect(page).to have_content(admin.user.username)
|
|
end
|
|
end
|
|
end
|
|
end
|