We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
30 lines
948 B
Ruby
30 lines
948 B
Ruby
require "spec_helper"
|
|
|
|
shared_examples_for "sluggable" do |updatable_slug_trait:|
|
|
describe "generate_slug" do
|
|
let(:factory_name) { described_class.name.parameterize(separator: "_").to_sym }
|
|
let(:sluggable) { create(factory_name, name: "Marló Brañido Carlo") }
|
|
|
|
context "when a new sluggable is created" do
|
|
it "gets a slug string" do
|
|
expect(sluggable.slug).to eq("marlo-branido-carlo")
|
|
end
|
|
end
|
|
|
|
context "slug updating condition is true" do
|
|
it "slug is updated" do
|
|
updatable = create(factory_name, updatable_slug_trait, name: "Old Name")
|
|
expect { updatable.update(name: "New Name") }
|
|
.to change { updatable.slug }.from("old-name").to("new-name")
|
|
end
|
|
end
|
|
|
|
context "slug updating condition is false" do
|
|
it "slug isn't updated" do
|
|
expect { sluggable.update(name: "New Name") }
|
|
.not_to change { sluggable.slug }
|
|
end
|
|
end
|
|
end
|
|
end
|