a29eeaf2e2
Similar to what we did in PR "Avoid duplicate records in poll answers" 5539,
specifically in commit 503369166, we want to stop relying on the plain text
"answer" and start using "option_id" to avoid issues with counts across
translations and to add consistency to the poll_partial_results table.
Note that we also moved the `possible_answers` method from Poll::Question to
Poll::Question::Option, since the list of valid answers really comes from the
options of a question and not from the question itself. Tests were updated
to validate answers against the translations of the assigned option.
Additionally, we renamed lambda parameters in validations to improve clarity.
31 lines
1.3 KiB
Ruby
31 lines
1.3 KiB
Ruby
class Poll::PartialResult < ApplicationRecord
|
|
VALID_ORIGINS = %w[web booth].freeze
|
|
|
|
belongs_to :question, -> { with_hidden }, inverse_of: :partial_results
|
|
belongs_to :author, -> { with_hidden }, class_name: "User", inverse_of: :poll_partial_results
|
|
belongs_to :booth_assignment
|
|
belongs_to :officer_assignment
|
|
belongs_to :option, class_name: "Poll::Question::Option"
|
|
|
|
validates :question, presence: true
|
|
validates :author, presence: true
|
|
validates :answer, presence: true
|
|
validates :answer, inclusion: { in: ->(partial_result) { partial_result.option.possible_answers }},
|
|
if: ->(partial_result) { partial_result.option.present? }
|
|
validates :origin, inclusion: { in: ->(*) { VALID_ORIGINS }}
|
|
validates :option, uniqueness: { scope: [:booth_assignment_id, :date] }, allow_nil: true
|
|
|
|
scope :by_author, ->(author_id) { where(author_id: author_id) }
|
|
scope :by_question, ->(question_id) { where(question_id: question_id) }
|
|
|
|
before_save :update_logs
|
|
|
|
def update_logs
|
|
if will_save_change_to_amount? && amount_in_database.present?
|
|
self.amount_log += ":#{amount_in_database}"
|
|
self.officer_assignment_id_log += ":#{officer_assignment_id_in_database}"
|
|
self.author_id_log += ":#{author_id_in_database}"
|
|
end
|
|
end
|
|
end
|