We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
32 lines
703 B
Ruby
32 lines
703 B
Ruby
class EmailDigest
|
|
attr_accessor :user
|
|
|
|
def initialize(user)
|
|
@user = user
|
|
end
|
|
|
|
def notifications
|
|
user.notifications.not_emailed.where(notifiable_type: "ProposalNotification")
|
|
end
|
|
|
|
def pending_notifications?
|
|
notifications.any?
|
|
end
|
|
|
|
def deliver(run_at)
|
|
if valid_email? && pending_notifications?
|
|
Mailer.delay(run_at: run_at).proposal_notification_digest(user, notifications.to_a)
|
|
mark_as_emailed
|
|
end
|
|
end
|
|
|
|
def mark_as_emailed
|
|
notifications.update_all(emailed_at: Time.current)
|
|
user.update!(failed_email_digests_count: 0)
|
|
end
|
|
|
|
def valid_email?
|
|
user.email.present? && user.email.match(/\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i)
|
|
end
|
|
end
|