1b8a079727
As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. For example, one of these tests has recently failed on our CI: ``` 3) Users Create a level 3 user with email from scratch Failure/Error: expect(user.reload).to be_confirmed expected `#<User id: 2060, email: "pepe@gmail.com", created_at: "2025-03-12 19:51:03.688867000 +0100", updated_...d_debates: true, recommended_proposals: true, subscriptions_token: nil, registering_from_web: false>.confirmed?` to be truthy, got false ``` IMHO this is also a bad practice for system tests, since these tests should be checking what users experience. So we're modifying the tests to check the results of users interaction from the point of view of the users. For example, instead of checking that a user is now level 3 verified in the database, we're checking that the user interface states that the user is level 3 verified. Note we're adding an offset when editing the map marker by clicking on `map-location` with `.click(x: 30, y: 30)`. This way we make sure that both the latitude and longitude change from the original values; we used to clicking in the middle (no offset), which didn't change the longitude and changed the latitude just by coincidence. Also note we aren't changing tests with the `:no_js` tag, since these tests don't run a real browser in a separate process. In the future, we should also change most of these tests so they don't access the database and they use a real browser.
87 lines
2.6 KiB
Ruby
87 lines
2.6 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Level three verification" do
|
|
scenario "Verification with residency and verified sms" do
|
|
allow_any_instance_of(Verification::Sms).to receive(:generate_confirmation_code).and_return("2015")
|
|
create(:geozone)
|
|
user = create(:user)
|
|
|
|
verified_user = create(:verified_user,
|
|
document_number: "12345678Z",
|
|
document_type: "1",
|
|
phone: "611111111")
|
|
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
verify_residence
|
|
|
|
within("#verified_user_#{verified_user.id}_phone") do
|
|
click_button "Send code"
|
|
end
|
|
|
|
expect(page).to have_content "Security code confirmation"
|
|
|
|
fill_in "sms_confirmation_code", with: "2015"
|
|
click_button "Send"
|
|
|
|
expect(page).to have_content "Code correct. Your account is now verified"
|
|
|
|
expect(page).not_to have_link "Verify my account"
|
|
expect(page).to have_content "Account verified"
|
|
end
|
|
|
|
scenario "Verification with residency and verified email" do
|
|
create(:geozone)
|
|
user = create(:user)
|
|
|
|
verified_user = create(:verified_user,
|
|
document_number: "12345678Z",
|
|
document_type: "1",
|
|
email: "rock@example.com")
|
|
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
verify_residence
|
|
|
|
within("#verified_user_#{verified_user.id}_email") do
|
|
click_button "Send code"
|
|
end
|
|
|
|
expect(page).to have_content "We have sent a confirmation email to your account: rock@example.com"
|
|
|
|
sent_token = /.*email_verification_token=(.*)".*/.match(ActionMailer::Base.deliveries.last.body.to_s)[1]
|
|
visit email_path(email_verification_token: sent_token)
|
|
|
|
expect(page).to have_content "You are a verified user"
|
|
|
|
expect(page).not_to have_link "Verify my account"
|
|
expect(page).to have_content "Account verified"
|
|
end
|
|
|
|
scenario "Verification with residency and sms and letter" do
|
|
allow_any_instance_of(Verification::Sms).to receive(:generate_confirmation_code).and_return("1234")
|
|
create(:geozone)
|
|
user = create(:user)
|
|
login_as(user)
|
|
|
|
visit account_path
|
|
click_link "Verify my account"
|
|
|
|
verify_residence
|
|
confirm_phone(code: "1234")
|
|
|
|
click_link "Send me a letter with the code"
|
|
|
|
expect(page).to have_content "Thank you for requesting your maximum security code " \
|
|
"(only required for the final votes). In a few days " \
|
|
"we will send it to the address featuring in the data " \
|
|
"we have on file."
|
|
end
|
|
end
|