Files
grecia/spec/models/concerns/globalizable.rb
Javi Martín 7ca55c44e0 Apply Rails/SaveBang rubocop rule
Having exceptions is better than having silent bugs.

There are a few methods I've kept the same way they were.

The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.

We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").

Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.

There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.

For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
2019-10-23 14:39:31 +02:00

192 lines
5.9 KiB
Ruby

require "spec_helper"
shared_examples_for "globalizable" do |factory_name|
let(:record) do
if factory_name == :budget_phase
create(:budget).phases.last
else
create(factory_name)
end
end
let(:fields) { record.translated_attribute_names }
let(:required_fields) { fields.select { |field| record.send(:required_attribute?, field) } }
let(:attribute) { required_fields.sample || fields.sample }
before do
record.update_attribute(attribute, "In English")
I18n.with_locale(:es) do
record.update!(required_fields.map { |field| [field, "En español"] }.to_h)
record.update_attribute(attribute, "En español")
end
record.reload
end
describe "Add a translation" do
it "Maintains existing translations" do
record.update!(translations_attributes: [
{ locale: :fr }.merge(fields.map { |field| [field, "En Français"] }.to_h)
])
record.reload
expect(record.send(attribute)).to eq "In English"
I18n.with_locale(:es) { expect(record.send(attribute)).to eq "En español" }
I18n.with_locale(:fr) { expect(record.send(attribute)).to eq "En Français" }
end
it "Works with non-underscored locale name" do
record.update!(translations_attributes: [
{ locale: :"pt-BR" }.merge(fields.map { |field| [field, "Português"] }.to_h)
])
record.reload
expect(record.send(attribute)).to eq "In English"
I18n.with_locale(:es) { expect(record.send(attribute)).to eq "En español" }
I18n.with_locale(:"pt-BR") { expect(record.send(attribute)).to eq "Português" }
end
it "Does not create invalid translations in the database" do
skip("cannot have invalid translations") if required_fields.empty?
record.update(translations_attributes: [{ locale: :fr }])
expect(record.translations.map(&:locale)).to match_array %i[en es fr]
record.reload
expect(record.translations.map(&:locale)).to match_array %i[en es]
end
it "Does not automatically add a translation for the current locale" do
record.translations.destroy_all
record.reload
record.update!(translations_attributes: [
{ locale: :de }.merge(fields.map { |field| [field, "Deutsch"] }.to_h)
])
record.reload
expect(record.translations.map(&:locale)).to eq [:de]
end
end
describe "Update a translation" do
it "Changes the existing translation" do
record.update!(translations_attributes: [
{ id: record.translations.find_by(locale: :es).id, attribute => "Actualizado" }
])
record.reload
expect(record.send(attribute)).to eq "In English"
I18n.with_locale(:es) { expect(record.send(attribute)).to eq "Actualizado" }
end
it "Does not save invalid translations" do
skip("cannot have invalid translations") if required_fields.empty?
record.update(translations_attributes: [
{ id: record.translations.find_by(locale: :es).id, attribute => "" }
])
I18n.with_locale(:es) { expect(record.send(attribute)).to eq "" }
record.reload
I18n.with_locale(:es) { expect(record.send(attribute)).to eq "En español" }
end
it "Does not automatically add a translation for the current locale" do
record.translations.find_by(locale: :en).destroy!
record.reload
record.update!(translations_attributes: [
{ id: record.translations.first.id }.merge(fields.map { |field| [field, "Cambiado"] }.to_h)
])
record.reload
expect(record.translations.map(&:locale)).to eq [:es]
end
end
describe "Remove a translation" do
it "Keeps the other languages" do
record.update!(translations_attributes: [
{ id: record.translations.find_by(locale: :en).id, _destroy: true }
])
record.reload
expect(record.translations.map(&:locale)).to eq [:es]
end
it "Does not remove all translations" do
skip("cannot have invalid translations") if required_fields.empty?
record.translations_attributes = [
{ id: record.translations.find_by(locale: :en).id, _destroy: true },
{ id: record.translations.find_by(locale: :es).id, _destroy: true }
]
expect(record).not_to be_valid
record.reload
expect(record.translations.map(&:locale)).to match_array %i[en es]
end
it "Does not remove translations when there's invalid data" do
skip("cannot have invalid translations") if required_fields.empty?
record.translations_attributes = [
{ id: record.translations.find_by(locale: :es).id, attribute => "" },
{ id: record.translations.find_by(locale: :en).id, _destroy: true },
]
expect(record).not_to be_valid
record.reload
expect(record.translations.map(&:locale)).to match_array %i[en es]
end
end
describe "Fallbacks" do
before do
I18n.with_locale(:de) do
record.update!(required_fields.map { |field| [field, "Deutsch"] }.to_h)
record.update_attribute(attribute, "Deutsch")
end
end
it "Falls back to a defined fallback" do
allow(I18n.fallbacks).to receive(:[]).and_return([:fr, :es])
Globalize.set_fallbacks_to_all_available_locales
I18n.with_locale(:fr) do
expect(record.send(attribute)).to eq "En español"
end
end
it "Falls back to the first available locale without a defined fallback" do
allow(I18n.fallbacks).to receive(:[]).and_return([:fr])
Globalize.set_fallbacks_to_all_available_locales
I18n.with_locale(:fr) do
expect(record.send(attribute)).to eq "Deutsch"
end
end
it "Falls back to the first available locale after removing a locale" do
expect(record.send(attribute)).to eq "In English"
record.update!(translations_attributes: [
{ id: record.translations.find_by(locale: :en).id, _destroy: true }
])
expect(record.send(attribute)).to eq "Deutsch"
end
end
end