db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
41 lines
1.1 KiB
Ruby
41 lines
1.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Valuation budgets" do
|
|
before do
|
|
valuator = create(:valuator, user: create(:user, username: "Rachel", email: "rachel@valuators.org"))
|
|
login_as(valuator.user)
|
|
end
|
|
|
|
scenario "Disabled with a feature flag" do
|
|
Setting["process.budgets"] = nil
|
|
expect { visit valuation_budgets_path }.to raise_exception(FeatureFlags::FeatureDisabled)
|
|
end
|
|
|
|
context "Index" do
|
|
scenario "Displaying budgets" do
|
|
budget = create(:budget)
|
|
visit valuation_budgets_path
|
|
|
|
expect(page).to have_content(budget.name)
|
|
end
|
|
|
|
scenario "Filters by phase" do
|
|
budget1 = create(:budget, :finished)
|
|
budget2 = create(:budget, :finished)
|
|
budget3 = create(:budget, :accepting)
|
|
|
|
visit valuation_budgets_path
|
|
|
|
expect(page).not_to have_content(budget1.name)
|
|
expect(page).not_to have_content(budget2.name)
|
|
expect(page).to have_content(budget3.name)
|
|
end
|
|
|
|
scenario "With no budgets" do
|
|
visit valuation_budgets_path
|
|
|
|
expect(page).to have_content "There are no budgets"
|
|
end
|
|
end
|
|
end
|