db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
94 lines
3.3 KiB
Ruby
94 lines
3.3 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin proposal notifications" do
|
|
before do
|
|
admin = create(:administrator)
|
|
login_as(admin.user)
|
|
end
|
|
|
|
scenario "List shows all relevant info" do
|
|
proposal_notification = create(:proposal_notification, :hidden)
|
|
visit admin_proposal_notifications_path
|
|
|
|
expect(page).to have_content(proposal_notification.title)
|
|
expect(page).to have_content(proposal_notification.body)
|
|
end
|
|
|
|
scenario "Restore" do
|
|
proposal_notification = create(:proposal_notification, :hidden, created_at: Date.current - 5.days)
|
|
visit admin_proposal_notifications_path
|
|
|
|
click_link "Restore"
|
|
|
|
expect(page).not_to have_content(proposal_notification.title)
|
|
|
|
expect(proposal_notification.reload).not_to be_hidden
|
|
expect(proposal_notification).to be_ignored
|
|
expect(proposal_notification).not_to be_moderated
|
|
end
|
|
|
|
scenario "Confirm hide" do
|
|
proposal_notification = create(:proposal_notification, :hidden, created_at: Date.current - 5.days)
|
|
visit admin_proposal_notifications_path
|
|
|
|
click_link "Confirm moderation"
|
|
|
|
expect(page).not_to have_content(proposal_notification.title)
|
|
click_link("Confirmed")
|
|
expect(page).to have_content(proposal_notification.title)
|
|
|
|
expect(proposal_notification.reload).to be_confirmed_hide
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit admin_proposal_notifications_path
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_proposal_notifications_path(filter: "Pending")
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_proposal_notifications_path(filter: "all")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_proposal_notifications_path(filter: "with_confirmed_hide")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("Confirmed")
|
|
end
|
|
|
|
scenario "Filtering proposals" do
|
|
create(:proposal_notification, :hidden, title: "Unconfirmed notification")
|
|
create(:proposal_notification, :hidden, :with_confirmed_hide, title: "Confirmed notification")
|
|
|
|
visit admin_proposal_notifications_path(filter: "pending")
|
|
expect(page).to have_content("Unconfirmed notification")
|
|
expect(page).not_to have_content("Confirmed notification")
|
|
|
|
visit admin_proposal_notifications_path(filter: "all")
|
|
expect(page).to have_content("Unconfirmed notification")
|
|
expect(page).to have_content("Confirmed notification")
|
|
|
|
visit admin_proposal_notifications_path(filter: "with_confirmed_hide")
|
|
expect(page).not_to have_content("Unconfirmed notification")
|
|
expect(page).to have_content("Confirmed notification")
|
|
end
|
|
|
|
scenario "Action links remember the pagination setting and the filter" do
|
|
per_page = Kaminari.config.default_per_page
|
|
(per_page + 2).times { create(:proposal_notification, :hidden, :with_confirmed_hide) }
|
|
|
|
visit admin_proposal_notifications_path(filter: "with_confirmed_hide", page: 2)
|
|
|
|
click_on("Restore", match: :first, exact: true)
|
|
|
|
expect(current_url).to include("filter=with_confirmed_hide")
|
|
expect(current_url).to include("page=2")
|
|
end
|
|
end
|