We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
48 lines
1.1 KiB
Ruby
48 lines
1.1 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Officer Assignments" do
|
|
before do
|
|
admin = create(:administrator)
|
|
login_as(admin.user)
|
|
end
|
|
|
|
scenario "Index" do
|
|
poll = create(:poll)
|
|
|
|
create(:poll_officer, name: "Bubbles", polls: [poll])
|
|
create(:poll_officer, name: "Blossom", polls: [poll])
|
|
create(:poll_officer, name: "Buttercup")
|
|
|
|
visit admin_poll_path(poll)
|
|
|
|
click_link "Officers (2)"
|
|
|
|
within("#officer_assignments") do
|
|
expect(page).to have_content "Bubbles"
|
|
expect(page).to have_content "Blossom"
|
|
expect(page).not_to have_content "Buttercup"
|
|
end
|
|
end
|
|
|
|
scenario "Search", :js do
|
|
poll = create(:poll)
|
|
|
|
create(:poll_officer, name: "John Snow", polls: [poll])
|
|
create(:poll_officer, name: "John Silver", polls: [poll])
|
|
create(:poll_officer, name: "John Edwards")
|
|
|
|
visit admin_poll_path(poll)
|
|
|
|
click_link "Officers (2)"
|
|
|
|
fill_in "search-officers", with: "John"
|
|
click_button "Search"
|
|
|
|
within("#search-officers-results") do
|
|
expect(page).to have_content "John Snow"
|
|
expect(page).to have_content "John Silver"
|
|
expect(page).not_to have_content "John Edwards"
|
|
end
|
|
end
|
|
end
|