We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
29 lines
990 B
Ruby
29 lines
990 B
Ruby
class Poll::PartialResult < ApplicationRecord
|
|
VALID_ORIGINS = %w[web booth]
|
|
|
|
belongs_to :question, -> { with_hidden }
|
|
belongs_to :author, -> { with_hidden }, class_name: "User", foreign_key: "author_id"
|
|
belongs_to :booth_assignment
|
|
belongs_to :officer_assignment
|
|
|
|
validates :question, presence: true
|
|
validates :author, presence: true
|
|
validates :answer, presence: true
|
|
validates :answer, inclusion: { in: -> (a) { a.question.possible_answers }},
|
|
unless: ->(a) { a.question.blank? }
|
|
validates :origin, inclusion: { in: VALID_ORIGINS }
|
|
|
|
scope :by_author, ->(author_id) { where(author_id: author_id) }
|
|
scope :by_question, ->(question_id) { where(question_id: question_id) }
|
|
|
|
before_save :update_logs
|
|
|
|
def update_logs
|
|
if amount_changed? && amount_was.present?
|
|
self.amount_log += ":#{amount_was}"
|
|
self.officer_assignment_id_log += ":#{officer_assignment_id_was}"
|
|
self.author_id_log += ":#{author_id_was}"
|
|
end
|
|
end
|
|
end
|