We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
28 lines
622 B
Ruby
28 lines
622 B
Ruby
|
|
require_dependency Rails.root.join("app", "models", "verification", "residence").to_s
|
|
|
|
class Verification::Residence
|
|
validate :postal_code_in_madrid
|
|
validate :residence_in_madrid
|
|
|
|
def postal_code_in_madrid
|
|
errors.add(:postal_code, I18n.t("verification.residence.new.error_not_allowed_postal_code")) unless valid_postal_code?
|
|
end
|
|
|
|
def residence_in_madrid
|
|
return if errors.any?
|
|
|
|
unless residency_valid?
|
|
errors.add(:residence_in_madrid, false)
|
|
store_failed_attempt
|
|
Lock.increase_tries(user)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def valid_postal_code?
|
|
postal_code =~ /^280/
|
|
end
|
|
end
|