We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
17 lines
496 B
Ruby
17 lines
496 B
Ruby
module BudgetExecutionsHelper
|
|
def filters_select_counts(status)
|
|
@budget.investments.winners.with_milestone_status_id(status).count
|
|
end
|
|
|
|
def options_for_milestone_tags
|
|
@budget.milestone_tags.map do |tag|
|
|
["#{tag} (#{@budget.investments.winners.tagged_with(tag).count})", tag]
|
|
end
|
|
end
|
|
|
|
def first_milestone_with_image(investment)
|
|
investment.milestones.order_by_publication_date
|
|
.select { |milestone| milestone.image.present? }.last
|
|
end
|
|
end
|