7ca55c44e0
Having exceptions is better than having silent bugs.
There are a few methods I've kept the same way they were.
The `RelatedContentScore#score_with_opposite` method is a bit peculiar:
it creates scores for both itself and the opposite related content,
which means the opposite related content will try to create the same
scores as well.
We've already got a test to check `Budget::Ballot#add_investment` when
creating a line fails ("Edge case voting a non-elegible investment").
Finally, the method `User#send_oauth_confirmation_instructions` doesn't
update the record when the email address isn't already present, leading
to the test "Try to register with the email of an already existing user,
when an unconfirmed email was provided by oauth" fo fail if we raise an
exception for an invalid user. That's because updating a user's email
doesn't update the database automatically, but instead a confirmation
email is sent.
There are also a few false positives for classes which don't have bang
methods (like the GraphQL classes) or destroying attachments.
For these reasons, I'm adding the rule with a "Refactor" severity,
meaning it's a rule we can break if necessary.
78 lines
1.9 KiB
Ruby
78 lines
1.9 KiB
Ruby
shared_examples "acts as imageable" do |imageable_factory|
|
|
|
|
let!(:image) { build(:image, imageable_factory.to_sym) }
|
|
let!(:imageable) { image.imageable }
|
|
|
|
it "is valid" do
|
|
expect(image).to be_valid
|
|
end
|
|
|
|
describe "file extension" do
|
|
|
|
it "is not valid with '.png' extension" do
|
|
image.attachment = File.new("spec/fixtures/files/clippy.png")
|
|
|
|
expect(image).not_to be_valid
|
|
expect(image.errors[:attachment].size).to eq(1)
|
|
end
|
|
|
|
it "is not valid with '.gif' extension" do
|
|
image.attachment = File.new("spec/fixtures/files/clippy.gif")
|
|
|
|
expect(image).not_to be_valid
|
|
expect(image.errors[:attachment].size).to eq(1)
|
|
end
|
|
|
|
it "is valid with '.jpg' extension" do
|
|
image.attachment = File.new("spec/fixtures/files/clippy.jpg")
|
|
|
|
expect(image).to be_valid
|
|
end
|
|
|
|
end
|
|
|
|
describe "image dimmessions" do
|
|
|
|
it "is valid when image dimmessions are 475X475 at least" do
|
|
expect(image).to be_valid
|
|
end
|
|
|
|
it "is not valid when image dimmensions are smaller than 475X475" do
|
|
image.attachment = File.new("spec/fixtures/files/logo_header.jpg")
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|
|
|
|
describe "title" do
|
|
|
|
it "is not valid when correct image attached but no image title provided" do
|
|
image.title = ""
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid when image title is too short" do
|
|
image.title = "a" * 3
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid when image title is too long" do
|
|
image.title = "a" * 81
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
end
|
|
|
|
it "image destroy should remove image from file storage" do
|
|
image.save!
|
|
image_url = image.attachment.url
|
|
new_url = "/attachments/original/missing.png"
|
|
|
|
expect { image.attachment.destroy }.to change { image.attachment.url }.from(image_url).to(new_url)
|
|
end
|
|
|
|
end
|