5311daadfe
Links acting like buttons have a few disadvantages.
First, screen readers will announce them as "links". Screen reader users
usually associate links with "things that get you somewhere" and buttons
with "things that perform an action". So when something like "Delete,
link" is announced, they'll probably think this is a link which will
take them to another page where they can delete a record.
Furthermore, the URL of the link for the "destroy" action might be the
same as the URL for the "show" action (only one is accessed with a
DELETE request and the other one with a GET request). That means screen
readers could announce the link like "Delete, visited link", which is
very confusing.
They also won't work when opening links in a new tab, since opening
links in a new tab always results in a GET request to the URL the link
points to.
Finally, submit buttons work without JavaScript enabled, so they'll work
even if the JavaScript in the page hasn't loaded (for whatever reason).
For all these reasons (and probably many more), using a button to send
forms is IMHO superior to using links.
There's one disadvantage, though. Using `button_to` we create a <form>
tag, which means we'll generate invalid HTML if the table is inside
another form. If we run into this issue, we need to use `button_tag`
with a `form` attribute and then generate a form somewhere else inside
the HTML (with `content_for`).
Note we're using `button_to` with a block so it generates a <button>
tag. Using it in a different way the text would result in an <input />
tag, and input elements can't have pseudocontent added via CSS.
The following code could be a starting point to use the `button_tag`
with a `form` attribute. One advantage of this approach is screen
readers wouldn't announce "leaving form" while navigating through these
buttons. However, it doesn't work in Internet Explorer.
```
ERB:
<% content_for(:hidden_content, form_tag(path, form_options) {}) %>
<%= button_tag text, button_options %>
Ruby:
def form_id
path.gsub("/", "_")
end
def form_options
{ id: form_id, method: options[:method] }
end
def button_options
html_options.except(:method).merge(form: form_id)
end
Layout:
<%= content_for :hidden_content %> # Right before the `</body>`
```
137 lines
4.9 KiB
Ruby
137 lines
4.9 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin hidden comments", :admin do
|
|
scenario "Do not show comments from blocked users" do
|
|
comment = create(:comment, :hidden, body: "SPAM from SPAMMER")
|
|
proposal = create(:proposal, author: comment.author)
|
|
create(:comment, commentable: proposal, user: comment.author, body: "Good Proposal!")
|
|
|
|
visit admin_hidden_comments_path
|
|
expect(page).to have_content("SPAM from SPAMMER")
|
|
expect(page).not_to have_content("Good Proposal!")
|
|
|
|
visit proposal_path(proposal)
|
|
|
|
within("#proposal_#{proposal.id}") do
|
|
accept_confirm { click_link "Hide author" }
|
|
end
|
|
|
|
expect(page).to have_current_path debates_path
|
|
|
|
visit admin_hidden_comments_path
|
|
|
|
expect(page).not_to have_content("SPAM from SPAMMER")
|
|
expect(page).not_to have_content("Good Proposal!")
|
|
end
|
|
|
|
scenario "Visit items with hidden comments" do
|
|
debate = create(:debate, title: "Debate with spam comment")
|
|
proposal = create(:proposal, title: "Proposal with spam comment")
|
|
create(:comment, :hidden, commentable: debate, body: "This is SPAM comment on debate")
|
|
create(:comment, :hidden, commentable: proposal, body: "This is SPAM comment on proposal")
|
|
|
|
visit admin_hidden_comments_path
|
|
|
|
expect(page).to have_content("Debate with spam comment")
|
|
expect(page).to have_content("Proposal with spam comment")
|
|
expect(page).to have_content("This is SPAM comment on debate")
|
|
expect(page).to have_content("This is SPAM comment on proposal")
|
|
|
|
click_link "Debate with spam comment"
|
|
expect(page).to have_content("Debate with spam comment")
|
|
expect(page).not_to have_content("This is SPAM comment on debate")
|
|
|
|
visit admin_hidden_comments_path
|
|
|
|
click_link "Proposal with spam comment"
|
|
expect(page).to have_content("Proposal with spam comment")
|
|
expect(page).not_to have_content("This is SPAM comment on proposal")
|
|
end
|
|
|
|
scenario "Don't show link on hidden items" do
|
|
debate = create(:debate, :hidden, title: "Hidden debate title")
|
|
proposal = create(:proposal, :hidden, title: "Hidden proposal title")
|
|
create(:comment, :hidden, commentable: debate, body: "This is SPAM comment on debate")
|
|
create(:comment, :hidden, commentable: proposal, body: "This is SPAM comment on proposal")
|
|
|
|
visit admin_hidden_comments_path
|
|
|
|
expect(page).to have_content("(Hidden proposal: Hidden proposal title)")
|
|
expect(page).to have_content("(Hidden debate: Hidden debate title)")
|
|
|
|
expect(page).not_to have_link("This is SPAM comment on debate")
|
|
expect(page).not_to have_link("This is SPAM comment on proposal")
|
|
end
|
|
|
|
scenario "Restore" do
|
|
comment = create(:comment, :hidden, body: "Not really SPAM")
|
|
visit admin_hidden_comments_path
|
|
|
|
accept_confirm { click_button "Restore" }
|
|
|
|
expect(page).not_to have_content(comment.body)
|
|
|
|
visit comment_path(comment)
|
|
|
|
expect(page).to have_content(comment.body)
|
|
end
|
|
|
|
scenario "Confirm hide" do
|
|
comment = create(:comment, :hidden, body: "SPAM")
|
|
visit admin_hidden_comments_path
|
|
|
|
click_button "Confirm moderation"
|
|
|
|
expect(page).not_to have_content(comment.body)
|
|
click_link("Confirmed")
|
|
expect(page).to have_content(comment.body)
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit admin_hidden_comments_path
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_hidden_comments_path(filter: "Pending")
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_hidden_comments_path(filter: "all")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_hidden_comments_path(filter: "with_confirmed_hide")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).not_to have_link("Confirmed")
|
|
end
|
|
|
|
scenario "Filtering comments" do
|
|
create(:comment, :hidden, body: "Unconfirmed comment")
|
|
create(:comment, :hidden, :with_confirmed_hide, body: "Confirmed comment")
|
|
|
|
visit admin_hidden_comments_path(filter: "all")
|
|
expect(page).to have_content("Unconfirmed comment")
|
|
expect(page).to have_content("Confirmed comment")
|
|
|
|
visit admin_hidden_comments_path(filter: "with_confirmed_hide")
|
|
expect(page).not_to have_content("Unconfirmed comment")
|
|
expect(page).to have_content("Confirmed comment")
|
|
end
|
|
|
|
scenario "Action links remember the pagination setting and the filter" do
|
|
allow(Comment).to receive(:default_per_page).and_return(2)
|
|
4.times { create(:comment, :hidden, :with_confirmed_hide) }
|
|
|
|
visit admin_hidden_comments_path(filter: "with_confirmed_hide", page: 2)
|
|
|
|
accept_confirm { click_button "Restore", match: :first, exact: true }
|
|
|
|
expect(page).to have_current_path(/filter=with_confirmed_hide/)
|
|
expect(page).to have_current_path(/page=2/)
|
|
end
|
|
end
|