We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
19 lines
738 B
Ruby
19 lines
738 B
Ruby
namespace :dashboards do
|
|
desc "Send to user notifications from new actions availability on dashboard"
|
|
task send_notifications: :environment do
|
|
Proposal.not_archived.each do |proposal|
|
|
new_actions_ids = Dashboard::Action.detect_new_actions_since(Date.yesterday, proposal)
|
|
|
|
if new_actions_ids.present?
|
|
if proposal.published?
|
|
Dashboard::Mailer.delay.new_actions_notification_rake_published(proposal,
|
|
new_actions_ids)
|
|
else
|
|
Dashboard::Mailer.delay.new_actions_notification_rake_created(proposal,
|
|
new_actions_ids)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|