5311daadfe
Links acting like buttons have a few disadvantages.
First, screen readers will announce them as "links". Screen reader users
usually associate links with "things that get you somewhere" and buttons
with "things that perform an action". So when something like "Delete,
link" is announced, they'll probably think this is a link which will
take them to another page where they can delete a record.
Furthermore, the URL of the link for the "destroy" action might be the
same as the URL for the "show" action (only one is accessed with a
DELETE request and the other one with a GET request). That means screen
readers could announce the link like "Delete, visited link", which is
very confusing.
They also won't work when opening links in a new tab, since opening
links in a new tab always results in a GET request to the URL the link
points to.
Finally, submit buttons work without JavaScript enabled, so they'll work
even if the JavaScript in the page hasn't loaded (for whatever reason).
For all these reasons (and probably many more), using a button to send
forms is IMHO superior to using links.
There's one disadvantage, though. Using `button_to` we create a <form>
tag, which means we'll generate invalid HTML if the table is inside
another form. If we run into this issue, we need to use `button_tag`
with a `form` attribute and then generate a form somewhere else inside
the HTML (with `content_for`).
Note we're using `button_to` with a block so it generates a <button>
tag. Using it in a different way the text would result in an <input />
tag, and input elements can't have pseudocontent added via CSS.
The following code could be a starting point to use the `button_tag`
with a `form` attribute. One advantage of this approach is screen
readers wouldn't announce "leaving form" while navigating through these
buttons. However, it doesn't work in Internet Explorer.
```
ERB:
<% content_for(:hidden_content, form_tag(path, form_options) {}) %>
<%= button_tag text, button_options %>
Ruby:
def form_id
path.gsub("/", "_")
end
def form_options
{ id: form_id, method: options[:method] }
end
def button_options
html_options.except(:method).merge(form: form_id)
end
Layout:
<%= content_for :hidden_content %> # Right before the `</body>`
```
87 lines
3.0 KiB
Ruby
87 lines
3.0 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Admin::TableActionsComponent, controller: Admin::BaseController do
|
|
let(:record) { create(:banner, title: "Important!") }
|
|
|
|
it "renders edit and destroy actions by default" do
|
|
render_inline Admin::TableActionsComponent.new(record)
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "a[href*='edit']", exact_text: "Edit"
|
|
expect(page).to have_css "a[aria-label='Edit Important!']"
|
|
|
|
expect(page).to have_button count: 1
|
|
expect(page).to have_css "button[aria-label='Delete Important!']", exact_text: "Delete"
|
|
expect(page).to have_css "input[name='_method'][value='delete']", visible: :hidden
|
|
end
|
|
|
|
context "actions parameter is passed" do
|
|
it "renders a link to edit a record if passed" do
|
|
render_inline Admin::TableActionsComponent.new(record, actions: [:edit])
|
|
|
|
expect(page).to have_link "Edit"
|
|
expect(page).not_to have_button "Delete"
|
|
end
|
|
|
|
it "renders a button to destroy a record if passed" do
|
|
render_inline Admin::TableActionsComponent.new(record, actions: [:destroy])
|
|
|
|
expect(page).to have_button "Delete"
|
|
expect(page).not_to have_link "Edit"
|
|
end
|
|
end
|
|
|
|
it "allows custom texts for actions" do
|
|
render_inline Admin::TableActionsComponent.new(record, edit_text: "change", destroy_text: "annihilate")
|
|
|
|
expect(page).to have_button "annihilate"
|
|
expect(page).to have_link "change"
|
|
expect(page).not_to have_button "Delete"
|
|
expect(page).not_to have_link "Edit"
|
|
end
|
|
|
|
it "allows custom URLs" do
|
|
render_inline Admin::TableActionsComponent.new(record, edit_path: "/myedit", destroy_path: "/mydestroy")
|
|
|
|
expect(page).to have_link "Edit", href: "/myedit"
|
|
expect(page).to have_css "form[action='/mydestroy']", exact_text: "Delete"
|
|
end
|
|
|
|
it "allows custom confirmation text" do
|
|
render_inline Admin::TableActionsComponent.new(record, destroy_confirmation: "Are you mad? Be careful!")
|
|
|
|
expect(page).to have_css "button[data-confirm='Are you mad? Be careful!']"
|
|
end
|
|
|
|
it "allows custom options" do
|
|
render_inline Admin::TableActionsComponent.new(record, edit_options: { id: "edit_me" })
|
|
|
|
expect(page).to have_css "a#edit_me"
|
|
end
|
|
|
|
it "allows custom content" do
|
|
render_inline Admin::TableActionsComponent.new(record) do
|
|
"<a href='/'>Main</a>".html_safe
|
|
end
|
|
|
|
expect(page).to have_css "a", count: 2
|
|
expect(page).to have_link "Main", href: "/"
|
|
expect(page).to have_link "Edit"
|
|
|
|
expect(page).to have_button count: 1
|
|
expect(page).to have_button "Delete"
|
|
end
|
|
|
|
context "different namespace" do
|
|
it "generates actions to different namespaces", controller: SDGManagement::BaseController do
|
|
render_inline Admin::TableActionsComponent.new(create(:sdg_local_target))
|
|
|
|
expect(page).to have_link count: 1
|
|
expect(page).to have_css "a[href^='/sdg_management/'][href*='edit']", exact_text: "Edit"
|
|
|
|
expect(page).to have_button count: 1
|
|
expect(page).to have_css "form[action^='/sdg_management/']", exact_text: "Delete"
|
|
end
|
|
end
|
|
end
|