5311daadfe
Links acting like buttons have a few disadvantages.
First, screen readers will announce them as "links". Screen reader users
usually associate links with "things that get you somewhere" and buttons
with "things that perform an action". So when something like "Delete,
link" is announced, they'll probably think this is a link which will
take them to another page where they can delete a record.
Furthermore, the URL of the link for the "destroy" action might be the
same as the URL for the "show" action (only one is accessed with a
DELETE request and the other one with a GET request). That means screen
readers could announce the link like "Delete, visited link", which is
very confusing.
They also won't work when opening links in a new tab, since opening
links in a new tab always results in a GET request to the URL the link
points to.
Finally, submit buttons work without JavaScript enabled, so they'll work
even if the JavaScript in the page hasn't loaded (for whatever reason).
For all these reasons (and probably many more), using a button to send
forms is IMHO superior to using links.
There's one disadvantage, though. Using `button_to` we create a <form>
tag, which means we'll generate invalid HTML if the table is inside
another form. If we run into this issue, we need to use `button_tag`
with a `form` attribute and then generate a form somewhere else inside
the HTML (with `content_for`).
Note we're using `button_to` with a block so it generates a <button>
tag. Using it in a different way the text would result in an <input />
tag, and input elements can't have pseudocontent added via CSS.
The following code could be a starting point to use the `button_tag`
with a `form` attribute. One advantage of this approach is screen
readers wouldn't announce "leaving form" while navigating through these
buttons. However, it doesn't work in Internet Explorer.
```
ERB:
<% content_for(:hidden_content, form_tag(path, form_options) {}) %>
<%= button_tag text, button_options %>
Ruby:
def form_id
path.gsub("/", "_")
end
def form_options
{ id: form_id, method: options[:method] }
end
def button_options
html_options.except(:method).merge(form: form_id)
end
Layout:
<%= content_for :hidden_content %> # Right before the `</body>`
```
175 lines
5.4 KiB
Ruby
175 lines
5.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin newsletter emails", :admin do
|
|
before do
|
|
create(:budget)
|
|
end
|
|
|
|
context "Show" do
|
|
scenario "Valid newsletter" do
|
|
newsletter = create(:newsletter, subject: "This is a subject",
|
|
segment_recipient: "all_users",
|
|
from: "no-reply@consul.dev",
|
|
body: "This is a body")
|
|
|
|
visit admin_newsletter_path(newsletter)
|
|
|
|
expect(page).to have_link "Go back", href: admin_newsletters_path
|
|
expect(page).to have_content "This is a subject"
|
|
expect(page).to have_content I18n.t("admin.segment_recipient.#{newsletter.segment_recipient}")
|
|
expect(page).to have_content "no-reply@consul.dev"
|
|
expect(page).to have_content "This is a body"
|
|
end
|
|
|
|
scenario "Invalid newsletter" do
|
|
invalid_newsletter = create(:newsletter)
|
|
invalid_newsletter.update_column(:segment_recipient, "invalid_segment")
|
|
|
|
visit admin_newsletter_path(invalid_newsletter)
|
|
|
|
expect(page).to have_content("Recipients user segment is invalid")
|
|
end
|
|
end
|
|
|
|
context "Index" do
|
|
scenario "Valid newsletters" do
|
|
newsletters = 3.times.map { create(:newsletter) }
|
|
|
|
visit admin_newsletters_path
|
|
|
|
expect(page).to have_css(".newsletter", count: 3)
|
|
|
|
newsletters.each do |newsletter|
|
|
segment_recipient = I18n.t("admin.segment_recipient.#{newsletter.segment_recipient}")
|
|
within("#newsletter_#{newsletter.id}") do
|
|
expect(page).to have_content newsletter.subject
|
|
expect(page).to have_content segment_recipient
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario "Invalid newsletter" do
|
|
invalid_newsletter = create(:newsletter)
|
|
invalid_newsletter.update_column(:segment_recipient, "invalid_segment")
|
|
|
|
visit admin_newsletters_path
|
|
|
|
expect(page).to have_content("Recipients user segment is invalid")
|
|
end
|
|
end
|
|
|
|
scenario "Create" do
|
|
visit admin_newsletters_path
|
|
click_link "New newsletter"
|
|
|
|
expect(page).to have_link "Go back", href: admin_newsletters_path
|
|
|
|
fill_in_newsletter_form(subject: "This is a subject",
|
|
segment_recipient: "Proposal authors",
|
|
body: "This is a body")
|
|
click_button "Create Newsletter"
|
|
|
|
expect(page).to have_content "Newsletter created successfully"
|
|
expect(page).to have_content "This is a subject"
|
|
expect(page).to have_content "Proposal authors"
|
|
expect(page).to have_content "no-reply@consul.dev"
|
|
expect(page).to have_content "This is a body"
|
|
end
|
|
|
|
scenario "Update" do
|
|
newsletter = create(:newsletter)
|
|
|
|
visit admin_newsletters_path
|
|
within("#newsletter_#{newsletter.id}") do
|
|
click_link "Edit"
|
|
end
|
|
|
|
expect(page).to have_link "Go back", href: admin_newsletters_path
|
|
|
|
fill_in_newsletter_form(subject: "This is a subject",
|
|
segment_recipient: "Investment authors in the current budget",
|
|
body: "This is a body")
|
|
click_button "Update Newsletter"
|
|
|
|
expect(page).to have_content "Newsletter updated successfully"
|
|
expect(page).to have_content "This is a subject"
|
|
expect(page).to have_content "Investment authors in the current budget"
|
|
expect(page).to have_content "no-reply@consul.dev"
|
|
expect(page).to have_content "This is a body"
|
|
end
|
|
|
|
scenario "Destroy" do
|
|
newsletter = create(:newsletter)
|
|
|
|
visit admin_newsletters_path
|
|
within("#newsletter_#{newsletter.id}") do
|
|
accept_confirm { click_button "Delete" }
|
|
end
|
|
|
|
expect(page).to have_content "Newsletter deleted successfully"
|
|
expect(page).to have_css(".newsletter", count: 0)
|
|
end
|
|
|
|
scenario "Errors on create" do
|
|
visit new_admin_newsletter_path
|
|
|
|
click_button "Create Newsletter"
|
|
|
|
expect(page).to have_content error_message
|
|
end
|
|
|
|
scenario "Errors on update" do
|
|
newsletter = create(:newsletter)
|
|
visit edit_admin_newsletter_path(newsletter)
|
|
|
|
fill_in "newsletter_subject", with: ""
|
|
click_button "Update Newsletter"
|
|
|
|
expect(page).to have_content error_message
|
|
end
|
|
|
|
context "Send newsletter" do
|
|
scenario "Sends newsletter emails" do
|
|
newsletter = create(:newsletter)
|
|
visit admin_newsletter_path(newsletter)
|
|
|
|
accept_confirm { click_link "Send" }
|
|
|
|
expect(page).to have_content "Newsletter sent successfully"
|
|
end
|
|
|
|
scenario "Invalid newsletter cannot be sent" do
|
|
invalid_newsletter = create(:newsletter)
|
|
invalid_newsletter.update_column(:segment_recipient, "invalid_segment")
|
|
visit admin_newsletter_path(invalid_newsletter)
|
|
|
|
expect(page).not_to have_link("Send")
|
|
end
|
|
end
|
|
|
|
context "Counter of emails sent" do
|
|
scenario "Display counter" do
|
|
newsletter = create(:newsletter, segment_recipient: "administrators")
|
|
visit admin_newsletter_path(newsletter)
|
|
|
|
accept_confirm { click_link "Send" }
|
|
|
|
expect(page).to have_content "Newsletter sent successfully"
|
|
|
|
expect(page).to have_content "1 affected users"
|
|
expect(page).to have_content "1 email sent"
|
|
end
|
|
end
|
|
|
|
scenario "Select list of users to send newsletter" do
|
|
UserSegments::SEGMENTS.each do |user_segment|
|
|
visit new_admin_newsletter_path
|
|
|
|
fill_in_newsletter_form(segment_recipient: I18n.t("admin.segment_recipient.#{user_segment}"))
|
|
click_button "Create Newsletter"
|
|
|
|
expect(page).to have_content(I18n.t("admin.segment_recipient.#{user_segment}"))
|
|
end
|
|
end
|
|
end
|