db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
71 lines
1.8 KiB
Ruby
71 lines
1.8 KiB
Ruby
shared_examples "image validations" do |imageable_factory|
|
|
include ImagesHelper
|
|
include ImageablesHelper
|
|
|
|
let!(:image) { build(:image, imageable_factory.to_sym) }
|
|
let!(:imageable) { image.imageable }
|
|
let!(:acceptedcontenttypes) { imageable_accepted_content_types }
|
|
|
|
it "is valid" do
|
|
expect(image).to be_valid
|
|
end
|
|
|
|
it "is not valid without a title" do
|
|
image.title = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without an attachment" do
|
|
image.attachment = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is valid for all accepted content types" do
|
|
acceptedcontenttypes.each do |content_type|
|
|
extension = content_type.split("/").last
|
|
image.attachment = File.new("spec/fixtures/files/clippy.#{extension}")
|
|
|
|
expect(image).to be_valid
|
|
end
|
|
end
|
|
|
|
it "is not valid for png and gif image content types" do
|
|
["gif", "png"].each do |content_type|
|
|
extension = content_type.split("/").last
|
|
image.attachment = File.new("spec/fixtures/files/clippy.#{extension}")
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|
|
|
|
it "is not valid for attachments larger than imageable max_file_size definition" do
|
|
larger_size = Setting["uploads.images.max_size"].to_i.megabytes + 1.byte
|
|
allow(image).to receive(:attachment_file_size).and_return(larger_size)
|
|
|
|
expect(image).not_to be_valid
|
|
expect(image.errors[:attachment]).to include "must be in between 0 Bytes and 1 MB"
|
|
end
|
|
|
|
it "is not valid without a user_id" do
|
|
image.user_id = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a imageable_id" do
|
|
image.save!
|
|
image.imageable_id = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a imageable_type" do
|
|
image.save!
|
|
image.imageable_type = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|