We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
30 lines
848 B
Ruby
30 lines
848 B
Ruby
require "rails_helper"
|
|
|
|
describe GeozonesHelper do
|
|
describe "#geozone_name" do
|
|
let(:geozone) { create :geozone }
|
|
|
|
it "returns geozone name if present" do
|
|
proposal = create(:proposal, geozone: geozone)
|
|
expect(geozone_name(proposal)).to eq geozone.name
|
|
end
|
|
|
|
it "returns default string for no geozone if geozone is blank" do
|
|
proposal = create(:proposal, geozone: nil)
|
|
expect(geozone_name(proposal)).to eq "All city"
|
|
end
|
|
end
|
|
|
|
describe "#geozone_select_options" do
|
|
it "returns array of ids and names ordered by name" do
|
|
g1 = create(:geozone, name: "AAA")
|
|
g3 = create(:geozone, name: "CCC")
|
|
g2 = create(:geozone, name: "BBB")
|
|
|
|
select_options = geozone_select_options
|
|
|
|
expect(select_options).to eq [[g1.name, g1.id], [g2.name, g2.id], [g3.name, g3.id]]
|
|
end
|
|
end
|
|
end
|