5311daadfe
Links acting like buttons have a few disadvantages.
First, screen readers will announce them as "links". Screen reader users
usually associate links with "things that get you somewhere" and buttons
with "things that perform an action". So when something like "Delete,
link" is announced, they'll probably think this is a link which will
take them to another page where they can delete a record.
Furthermore, the URL of the link for the "destroy" action might be the
same as the URL for the "show" action (only one is accessed with a
DELETE request and the other one with a GET request). That means screen
readers could announce the link like "Delete, visited link", which is
very confusing.
They also won't work when opening links in a new tab, since opening
links in a new tab always results in a GET request to the URL the link
points to.
Finally, submit buttons work without JavaScript enabled, so they'll work
even if the JavaScript in the page hasn't loaded (for whatever reason).
For all these reasons (and probably many more), using a button to send
forms is IMHO superior to using links.
There's one disadvantage, though. Using `button_to` we create a <form>
tag, which means we'll generate invalid HTML if the table is inside
another form. If we run into this issue, we need to use `button_tag`
with a `form` attribute and then generate a form somewhere else inside
the HTML (with `content_for`).
Note we're using `button_to` with a block so it generates a <button>
tag. Using it in a different way the text would result in an <input />
tag, and input elements can't have pseudocontent added via CSS.
The following code could be a starting point to use the `button_tag`
with a `form` attribute. One advantage of this approach is screen
readers wouldn't announce "leaving form" while navigating through these
buttons. However, it doesn't work in Internet Explorer.
```
ERB:
<% content_for(:hidden_content, form_tag(path, form_options) {}) %>
<%= button_tag text, button_options %>
Ruby:
def form_id
path.gsub("/", "_")
end
def form_options
{ id: form_id, method: options[:method] }
end
def button_options
html_options.except(:method).merge(form: form_id)
end
Layout:
<%= content_for :hidden_content %> # Right before the `</body>`
```
89 lines
3.3 KiB
Ruby
89 lines
3.3 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin proposal notifications", :admin do
|
|
scenario "List shows all relevant info" do
|
|
proposal_notification = create(:proposal_notification, :hidden)
|
|
visit admin_hidden_proposal_notifications_path
|
|
|
|
expect(page).to have_content(proposal_notification.title)
|
|
expect(page).to have_content(proposal_notification.body)
|
|
end
|
|
|
|
scenario "Restore" do
|
|
proposal_notification = create(:proposal_notification, :hidden, created_at: Date.current - 5.days)
|
|
visit admin_hidden_proposal_notifications_path
|
|
|
|
accept_confirm { click_button "Restore" }
|
|
|
|
expect(page).not_to have_content(proposal_notification.title)
|
|
|
|
logout
|
|
login_as(proposal_notification.author)
|
|
visit proposal_notification_path(proposal_notification)
|
|
|
|
expect(page).to have_content(proposal_notification.title)
|
|
end
|
|
|
|
scenario "Confirm hide" do
|
|
proposal_notification = create(:proposal_notification, :hidden, created_at: Date.current - 5.days)
|
|
visit admin_hidden_proposal_notifications_path
|
|
|
|
click_button "Confirm moderation"
|
|
|
|
expect(page).not_to have_content(proposal_notification.title)
|
|
click_link("Confirmed")
|
|
expect(page).to have_content(proposal_notification.title)
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit admin_hidden_proposal_notifications_path
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "Pending")
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "all")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("All")
|
|
expect(page).to have_link("Confirmed")
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "with_confirmed_hide")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("Confirmed")
|
|
end
|
|
|
|
scenario "Filtering proposals" do
|
|
create(:proposal_notification, :hidden, title: "Unconfirmed notification")
|
|
create(:proposal_notification, :hidden, :with_confirmed_hide, title: "Confirmed notification")
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "pending")
|
|
expect(page).to have_content("Unconfirmed notification")
|
|
expect(page).not_to have_content("Confirmed notification")
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "all")
|
|
expect(page).to have_content("Unconfirmed notification")
|
|
expect(page).to have_content("Confirmed notification")
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "with_confirmed_hide")
|
|
expect(page).not_to have_content("Unconfirmed notification")
|
|
expect(page).to have_content("Confirmed notification")
|
|
end
|
|
|
|
scenario "Action links remember the pagination setting and the filter" do
|
|
allow(ProposalNotification).to receive(:default_per_page).and_return(2)
|
|
4.times { create(:proposal_notification, :hidden, :with_confirmed_hide) }
|
|
|
|
visit admin_hidden_proposal_notifications_path(filter: "with_confirmed_hide", page: 2)
|
|
|
|
accept_confirm { click_button "Restore", match: :first, exact: true }
|
|
|
|
expect(page).to have_current_path(/filter=with_confirmed_hide/)
|
|
expect(page).to have_current_path(/page=2/)
|
|
end
|
|
end
|