5311daadfe
Links acting like buttons have a few disadvantages.
First, screen readers will announce them as "links". Screen reader users
usually associate links with "things that get you somewhere" and buttons
with "things that perform an action". So when something like "Delete,
link" is announced, they'll probably think this is a link which will
take them to another page where they can delete a record.
Furthermore, the URL of the link for the "destroy" action might be the
same as the URL for the "show" action (only one is accessed with a
DELETE request and the other one with a GET request). That means screen
readers could announce the link like "Delete, visited link", which is
very confusing.
They also won't work when opening links in a new tab, since opening
links in a new tab always results in a GET request to the URL the link
points to.
Finally, submit buttons work without JavaScript enabled, so they'll work
even if the JavaScript in the page hasn't loaded (for whatever reason).
For all these reasons (and probably many more), using a button to send
forms is IMHO superior to using links.
There's one disadvantage, though. Using `button_to` we create a <form>
tag, which means we'll generate invalid HTML if the table is inside
another form. If we run into this issue, we need to use `button_tag`
with a `form` attribute and then generate a form somewhere else inside
the HTML (with `content_for`).
Note we're using `button_to` with a block so it generates a <button>
tag. Using it in a different way the text would result in an <input />
tag, and input elements can't have pseudocontent added via CSS.
The following code could be a starting point to use the `button_tag`
with a `form` attribute. One advantage of this approach is screen
readers wouldn't announce "leaving form" while navigating through these
buttons. However, it doesn't work in Internet Explorer.
```
ERB:
<% content_for(:hidden_content, form_tag(path, form_options) {}) %>
<%= button_tag text, button_options %>
Ruby:
def form_id
path.gsub("/", "_")
end
def form_options
{ id: form_id, method: options[:method] }
end
def button_options
html_options.except(:method).merge(form: form_id)
end
Layout:
<%= content_for :hidden_content %> # Right before the `</body>`
```
89 lines
2.4 KiB
Ruby
89 lines
2.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin milestone statuses", :admin do
|
|
context "Index" do
|
|
scenario "Displaying only not hidden statuses" do
|
|
status1 = create(:milestone_status)
|
|
status2 = create(:milestone_status)
|
|
|
|
status1.destroy!
|
|
|
|
visit admin_milestone_statuses_path
|
|
|
|
expect(page).not_to have_content status1.name
|
|
expect(page).not_to have_content status1.description
|
|
|
|
expect(page).to have_content status2.name
|
|
expect(page).to have_content status2.description
|
|
end
|
|
|
|
scenario "Displaying no statuses text" do
|
|
visit admin_milestone_statuses_path
|
|
|
|
expect(page).to have_content("There are no milestone statuses created")
|
|
end
|
|
end
|
|
|
|
context "New" do
|
|
scenario "Create status" do
|
|
visit admin_milestone_statuses_path
|
|
|
|
click_link "Create new milestone status"
|
|
|
|
fill_in "milestone_status_name", with: "New status name"
|
|
fill_in "milestone_status_description", with: "This status description"
|
|
click_button "Create Milestone Status"
|
|
|
|
expect(page).to have_content "New status name"
|
|
expect(page).to have_content "This status description"
|
|
end
|
|
|
|
scenario "Show validation errors in status form" do
|
|
visit admin_milestone_statuses_path
|
|
|
|
click_link "Create new milestone status"
|
|
|
|
fill_in "milestone_status_description", with: "This status description"
|
|
click_button "Create Milestone Status"
|
|
|
|
within "#new_milestone_status" do
|
|
expect(page).to have_content "can't be blank", count: 1
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Edit" do
|
|
scenario "Change name and description" do
|
|
status = create(:milestone_status)
|
|
|
|
visit admin_milestone_statuses_path
|
|
|
|
within("#milestone_status_#{status.id}") do
|
|
click_link "Edit"
|
|
end
|
|
|
|
fill_in "milestone_status_name", with: "Other status name"
|
|
fill_in "milestone_status_description", with: "Other status description"
|
|
click_button "Update Milestone Status"
|
|
|
|
expect(page).to have_content "Other status name"
|
|
expect(page).to have_content "Other status description"
|
|
end
|
|
end
|
|
|
|
context "Delete" do
|
|
scenario "Hides status" do
|
|
status = create(:milestone_status)
|
|
|
|
visit admin_milestone_statuses_path
|
|
|
|
within("#milestone_status_#{status.id}") do
|
|
accept_confirm { click_button "Delete" }
|
|
end
|
|
|
|
expect(page).not_to have_content status.name
|
|
expect(page).not_to have_content status.description
|
|
end
|
|
end
|
|
end
|