5311daadfe
Links acting like buttons have a few disadvantages.
First, screen readers will announce them as "links". Screen reader users
usually associate links with "things that get you somewhere" and buttons
with "things that perform an action". So when something like "Delete,
link" is announced, they'll probably think this is a link which will
take them to another page where they can delete a record.
Furthermore, the URL of the link for the "destroy" action might be the
same as the URL for the "show" action (only one is accessed with a
DELETE request and the other one with a GET request). That means screen
readers could announce the link like "Delete, visited link", which is
very confusing.
They also won't work when opening links in a new tab, since opening
links in a new tab always results in a GET request to the URL the link
points to.
Finally, submit buttons work without JavaScript enabled, so they'll work
even if the JavaScript in the page hasn't loaded (for whatever reason).
For all these reasons (and probably many more), using a button to send
forms is IMHO superior to using links.
There's one disadvantage, though. Using `button_to` we create a <form>
tag, which means we'll generate invalid HTML if the table is inside
another form. If we run into this issue, we need to use `button_tag`
with a `form` attribute and then generate a form somewhere else inside
the HTML (with `content_for`).
Note we're using `button_to` with a block so it generates a <button>
tag. Using it in a different way the text would result in an <input />
tag, and input elements can't have pseudocontent added via CSS.
The following code could be a starting point to use the `button_tag`
with a `form` attribute. One advantage of this approach is screen
readers wouldn't announce "leaving form" while navigating through these
buttons. However, it doesn't work in Internet Explorer.
```
ERB:
<% content_for(:hidden_content, form_tag(path, form_options) {}) %>
<%= button_tag text, button_options %>
Ruby:
def form_id
path.gsub("/", "_")
end
def form_options
{ id: form_id, method: options[:method] }
end
def button_options
html_options.except(:method).merge(form: form_id)
end
Layout:
<%= content_for :hidden_content %> # Right before the `</body>`
```
230 lines
7.7 KiB
Ruby
230 lines
7.7 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Admin Notifications", :admin do
|
|
before { create(:budget) }
|
|
|
|
context "Show" do
|
|
scenario "Valid Admin Notification" do
|
|
notification = create(:admin_notification, title: "Notification title",
|
|
body: "Notification body",
|
|
link: "https://www.decide.madrid.es/vota",
|
|
segment_recipient: :all_users)
|
|
|
|
visit admin_admin_notification_path(notification)
|
|
|
|
expect(page).to have_content("Notification title")
|
|
expect(page).to have_content("Notification body")
|
|
expect(page).to have_content("https://www.decide.madrid.es/vota")
|
|
expect(page).to have_content("All users")
|
|
end
|
|
|
|
scenario "Notification with invalid segment recipient" do
|
|
invalid_notification = create(:admin_notification)
|
|
invalid_notification.update_column(:segment_recipient, "invalid_segment")
|
|
|
|
visit admin_admin_notification_path(invalid_notification)
|
|
|
|
expect(page).to have_content("Recipients user segment is invalid")
|
|
end
|
|
end
|
|
|
|
context "Index" do
|
|
scenario "Valid Admin Notifications", :with_frozen_time do
|
|
draft = create(:admin_notification, segment_recipient: :all_users, title: "Not yet sent")
|
|
sent = create(:admin_notification, :sent, segment_recipient: :administrators,
|
|
title: "Sent one")
|
|
|
|
visit admin_admin_notifications_path
|
|
|
|
expect(page).to have_css(".admin_notification", count: 2)
|
|
|
|
within("#admin_notification_#{draft.id}") do
|
|
expect(page).to have_content("Not yet sent")
|
|
expect(page).to have_content("All users")
|
|
expect(page).to have_content("Draft")
|
|
end
|
|
|
|
within("#admin_notification_#{sent.id}") do
|
|
expect(page).to have_content("Sent one")
|
|
expect(page).to have_content("Administrators")
|
|
expect(page).to have_content(I18n.l(Date.current))
|
|
end
|
|
end
|
|
|
|
scenario "Notifications with invalid segment recipient" do
|
|
invalid_notification = create(:admin_notification)
|
|
invalid_notification.update_column(:segment_recipient, "invalid_segment")
|
|
|
|
visit admin_admin_notifications_path
|
|
|
|
expect(page).to have_content("Recipients user segment is invalid")
|
|
end
|
|
end
|
|
|
|
scenario "Create" do
|
|
visit admin_admin_notifications_path
|
|
click_link "New notification"
|
|
|
|
fill_in_admin_notification_form(segment_recipient: "Proposal authors",
|
|
title: "This is a title",
|
|
body: "This is a body",
|
|
link: "http://www.dummylink.dev")
|
|
|
|
click_button "Create notification"
|
|
|
|
expect(page).to have_content "Notification created successfully"
|
|
expect(page).to have_content "Proposal authors"
|
|
expect(page).to have_content "This is a title"
|
|
expect(page).to have_content "This is a body"
|
|
expect(page).to have_content "http://www.dummylink.dev"
|
|
end
|
|
|
|
context "Update" do
|
|
scenario "A draft notification can be updated" do
|
|
notification = create(:admin_notification)
|
|
|
|
visit admin_admin_notifications_path
|
|
within("#admin_notification_#{notification.id}") do
|
|
click_link "Edit"
|
|
end
|
|
|
|
fill_in_admin_notification_form(segment_recipient: "All users",
|
|
title: "Other title",
|
|
body: "Other body",
|
|
link: "")
|
|
|
|
click_button "Update notification"
|
|
|
|
expect(page).to have_content "Notification updated successfully"
|
|
expect(page).to have_content "All users"
|
|
expect(page).to have_content "Other title"
|
|
expect(page).to have_content "Other body"
|
|
expect(page).not_to have_content "http://www.dummylink.dev"
|
|
end
|
|
|
|
scenario "Sent notification can not be updated" do
|
|
notification = create(:admin_notification, :sent)
|
|
|
|
visit admin_admin_notifications_path
|
|
within("#admin_notification_#{notification.id}") do
|
|
expect(page).not_to have_link("Edit")
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Destroy" do
|
|
scenario "A draft notification can be destroyed" do
|
|
notification = create(:admin_notification)
|
|
|
|
visit admin_admin_notifications_path
|
|
within("#admin_notification_#{notification.id}") do
|
|
accept_confirm { click_button "Delete" }
|
|
end
|
|
|
|
expect(page).to have_content "Notification deleted successfully"
|
|
expect(page).to have_css(".notification", count: 0)
|
|
end
|
|
|
|
scenario "Sent notification can not be destroyed" do
|
|
notification = create(:admin_notification, :sent)
|
|
|
|
visit admin_admin_notifications_path
|
|
|
|
within("#admin_notification_#{notification.id}") do
|
|
expect(page).not_to have_button "Delete"
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Visualize" do
|
|
scenario "A draft notification can be previewed" do
|
|
notification = create(:admin_notification, segment_recipient: :administrators)
|
|
|
|
visit admin_admin_notifications_path
|
|
within("#admin_notification_#{notification.id}") do
|
|
click_link "Preview"
|
|
end
|
|
|
|
expect(page).to have_content "This is how the users will see the notification:"
|
|
expect(page).to have_content "Administrators (1 users will be notified)"
|
|
end
|
|
|
|
scenario "A sent notification can be viewed" do
|
|
notification = create(:admin_notification, :sent, recipients_count: 7,
|
|
segment_recipient: :administrators)
|
|
|
|
visit admin_admin_notifications_path
|
|
within("#admin_notification_#{notification.id}") do
|
|
click_link "View"
|
|
end
|
|
|
|
expect(page).to have_content "This is how the users see the notification:"
|
|
expect(page).to have_content "Administrators (7 users got notified)"
|
|
end
|
|
end
|
|
|
|
scenario "Errors on create" do
|
|
visit new_admin_admin_notification_path
|
|
|
|
click_button "Create notification"
|
|
|
|
expect(page).to have_content error_message
|
|
end
|
|
|
|
scenario "Errors on update" do
|
|
notification = create(:admin_notification)
|
|
visit edit_admin_admin_notification_path(notification)
|
|
|
|
fill_in "Title", with: ""
|
|
click_button "Update notification"
|
|
|
|
expect(page).to have_content error_message
|
|
end
|
|
|
|
context "Send notification" do
|
|
scenario "A draft Admin notification can be sent" do
|
|
2.times { create(:user) }
|
|
notification = create(:admin_notification, segment_recipient: :all_users)
|
|
|
|
visit admin_admin_notification_path(notification)
|
|
|
|
accept_confirm { click_link "Send notification" }
|
|
|
|
expect(page).to have_content "Notification sent successfully"
|
|
|
|
User.find_each do |user|
|
|
expect(user.notifications.count).to eq(1)
|
|
end
|
|
end
|
|
|
|
scenario "A sent Admin notification can not be sent" do
|
|
notification = create(:admin_notification, :sent)
|
|
|
|
visit admin_admin_notification_path(notification)
|
|
|
|
expect(page).not_to have_link("Send")
|
|
end
|
|
|
|
scenario "Admin notification with invalid segment recipient cannot be sent" do
|
|
invalid_notification = create(:admin_notification)
|
|
invalid_notification.update_column(:segment_recipient, "invalid_segment")
|
|
visit admin_admin_notification_path(invalid_notification)
|
|
|
|
expect(page).not_to have_link("Send")
|
|
end
|
|
end
|
|
|
|
scenario "Select list of users to send notification" do
|
|
UserSegments::SEGMENTS.each do |user_segment|
|
|
segment_recipient = I18n.t("admin.segment_recipient.#{user_segment}")
|
|
|
|
visit new_admin_admin_notification_path
|
|
|
|
fill_in_admin_notification_form(segment_recipient: segment_recipient)
|
|
click_button "Create notification"
|
|
|
|
expect(page).to have_content(I18n.t("admin.segment_recipient.#{user_segment}"))
|
|
end
|
|
end
|
|
end
|