We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
13 lines
441 B
Ruby
13 lines
441 B
Ruby
class CensusCaller
|
|
def call(document_type, document_number, date_of_birth, postal_code)
|
|
if Setting["feature.remote_census"].present?
|
|
response = RemoteCensusApi.new.call(document_type, document_number, date_of_birth, postal_code)
|
|
else
|
|
response = CensusApi.new.call(document_type, document_number)
|
|
end
|
|
response = LocalCensus.new.call(document_type, document_number) unless response.valid?
|
|
|
|
response
|
|
end
|
|
end
|