Files
grecia/spec/routing/polymorphic_routes_spec.rb
Javi Martín 38b38d1fcc Rename Poll::Question::Answer to Poll::Question::Option
Having a class named `Poll::Question::Answer` and another class named
`Poll::Answer` was so confusing that no developer working on the project
has ever been capable of remembering which is which for more than a few
seconds.

Furthermore, we're planning to add open answers to polls, and we might
add a reference from the `poll_answers` table to the
`poll_question_answers` table to property differentiate between open
answers and closed answers. Having yet another thing named answer would
be more than what our brains can handle (we know it because we did this
once in a prototype).

So we're renaming `Poll::Question::Answer` to `Poll::Question::Option`.
Hopefully that'll make it easier to remember. The name is also (more or
less) consistent with the `Legislation::QuestionOption` class, which is
similar.

We aren't changing the table or columns names for now in order to avoid
possible issues when upgrading (old code running with the new database
tables/columns after running the migrations but before deployment has
finished, for instance). We might do it in the future.

I've tried not to change the internationalization keys either so
existing translations would still be valid. However, since we have to
change the keys in `activerecord.yml` so methods like
`human_attribute_name` keep working, I'm also changing them in places
where similar keys were used (like `poll_question_answer` or
`poll/question/answer`).

Note that it isn't clear whether we should use `option` or
`question_option` in some cases. In order to keep things simple, we're
using `option` where we were using `answer` and `question_option` where
we were using `question_answer`.

Also note we're adding tests for the admin menu component, since at
first I forgot to change the `answers` reference there and all tests
passed.
2024-06-13 19:13:01 +02:00

233 lines
7.5 KiB
Ruby

require "rails_helper"
describe "Polymorphic routes" do
describe "polymorphic_path" do
it "routes investments" do
budget = create(:budget)
investment = create(:budget_investment, budget: budget)
expect(polymorphic_path(investment)).to eq budget_investment_path(budget, investment)
end
it "routes legislation proposals" do
process = create(:legislation_process)
proposal = create(:legislation_proposal, process: process)
expect(polymorphic_path(proposal)).to eq legislation_process_proposal_path(process, proposal)
end
it "routes legislation proposals vote" do
process = create(:legislation_process)
proposal = create(:legislation_proposal, process: process)
path = polymorphic_path(Vote.new(votable: proposal), value: true)
expect(path).to eq legislation_process_legislation_proposal_votes_path(process, proposal, value: true)
end
it "routes legislation proposals remove vote" do
process = create(:legislation_process)
proposal = create(:legislation_proposal, process: process)
vote = create(:vote, votable: proposal)
path = polymorphic_path(vote, value: true)
expect(path).to eq legislation_process_legislation_proposal_vote_path(process,
proposal,
vote,
value: true)
end
it "routes legislation questions" do
process = create(:legislation_process)
question = create(:legislation_question, process: process)
expect(polymorphic_path(question)).to eq legislation_process_question_path(process, question)
end
it "routes legislation annotations" do
process = create(:legislation_process)
draft_version = create(:legislation_draft_version, process: process)
annotation = create(:legislation_annotation, draft_version: draft_version)
expect(polymorphic_path(annotation)).to eq(
legislation_process_draft_version_annotation_path(process, draft_version, annotation)
)
end
it "routes poll questions" do
question = create(:poll_question)
expect(polymorphic_path(question)).to eq question_path(question)
end
it "routes topics" do
community = create(:proposal).community
topic = create(:topic, community: community)
expect(polymorphic_path(topic)).to eq community_topic_path(community, topic)
end
end
describe "admin_polymorphic_path" do
include ActionDispatch::Routing::UrlFor
it "routes budget investments" do
budget = create(:budget)
investment = create(:budget_investment, budget: budget)
expect(admin_polymorphic_path(investment)).to eq(
admin_budget_budget_investment_path(budget, investment)
)
end
it "routes budget groups" do
budget = create(:budget)
group = create(:budget_group, budget: budget)
expect(admin_polymorphic_path(group)).to eq(admin_budget_group_path(budget, group))
end
it "routes budget headings" do
budget = create(:budget)
group = create(:budget_group, budget: budget)
heading = create(:budget_heading, group: group)
expect(admin_polymorphic_path(heading)).to eq(
admin_budget_group_heading_path(budget, group, heading)
)
end
it "routes poll booths" do
booth = create(:poll_booth)
expect(admin_polymorphic_path(booth)).to eq(admin_booth_path(booth))
end
it "routes poll officers" do
officer = create(:poll_officer)
expect(admin_polymorphic_path(officer)).to eq admin_officer_path(officer)
end
it "routes poll questions" do
question = create(:poll_question)
expect(admin_polymorphic_path(question)).to eq(admin_question_path(question))
end
it "routes poll answer videos" do
video = create(:poll_option_video)
expect(admin_polymorphic_path(video)).to eq admin_option_video_path(video.option, video)
end
it "routes milestones for resources with no hierarchy" do
proposal = create(:proposal)
milestone = create(:milestone, milestoneable: proposal)
expect(admin_polymorphic_path(milestone)).to eq(
admin_proposal_milestone_path(proposal, milestone)
)
end
it "routes milestones for resources with hierarchy" do
budget = create(:budget)
investment = create(:budget_investment, budget: budget)
milestone = create(:milestone, milestoneable: investment)
expect(admin_polymorphic_path(milestone)).to eq(
admin_budget_budget_investment_milestone_path(budget, investment, milestone)
)
end
it "routes progress bars for resources with no hierarchy" do
proposal = create(:proposal)
progress_bar = create(:progress_bar, progressable: proposal)
expect(admin_polymorphic_path(progress_bar)).to eq(
admin_proposal_progress_bar_path(proposal, progress_bar)
)
end
it "routes progress_bars for resources with hierarchy" do
budget = create(:budget)
investment = create(:budget_investment, budget: budget)
progress_bar = create(:progress_bar, progressable: investment)
expect(admin_polymorphic_path(progress_bar)).to eq(
admin_budget_budget_investment_progress_bar_path(budget, investment, progress_bar)
)
end
it "routes audits" do
budget = create(:budget)
investment = create(:budget_investment, budget: budget)
audit = investment.audits.create!
expect(admin_polymorphic_path(audit)).to eq(
admin_budget_budget_investment_audit_path(budget, investment, audit)
)
end
it "routes booth assignments" do
poll = create(:poll)
assignment = create(:poll_booth_assignment, poll: poll)
expect(admin_polymorphic_path(assignment)).to eq(
admin_poll_booth_assignment_path(poll, assignment)
)
end
it "routes poll shifts" do
booth = create(:poll_booth)
shift = create(:poll_shift, booth: booth)
expect(admin_polymorphic_path(shift)).to eq(admin_booth_shift_path(booth, shift))
end
it "routes widget cards" do
card = create(:widget_card)
expect(admin_polymorphic_path(card)).to eq(admin_widget_card_path(card))
end
it "routes site customization page widget cards" do
page = create(:site_customization_page)
card = create(:widget_card, cardable: page)
expect(admin_polymorphic_path(card)).to eq admin_site_customization_page_widget_card_path(page, card)
end
it "supports routes for actions like edit" do
proposal = create(:proposal)
milestone = create(:milestone, milestoneable: proposal)
expect(admin_polymorphic_path(milestone, action: :edit)).to eq(
edit_admin_proposal_milestone_path(proposal, milestone)
)
end
end
describe "sdg_management_polymorphic_path" do
include ActionDispatch::Routing::UrlFor
it "routes local targets" do
target = create(:sdg_local_target)
expect(sdg_management_polymorphic_path(target)).to eq sdg_management_local_target_path(target)
end
it "routes SDG phases widget cards" do
phase = SDG::Phase.sample
card = create(:widget_card, cardable: phase)
expect(sdg_management_polymorphic_path(card)).to eq(
sdg_management_sdg_phase_widget_card_path(phase, card)
)
end
end
end
def polymorphic_path(record, options = {})
super(record, options.merge(only_path: true))
end