We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
18 lines
350 B
Ruby
18 lines
350 B
Ruby
class EvaluationCommentNotifier
|
|
def initialize(args = {})
|
|
@comment = args.fetch(:comment)
|
|
end
|
|
|
|
def process
|
|
send_evaluation_comment_email
|
|
end
|
|
|
|
private
|
|
|
|
def send_evaluation_comment_email
|
|
EvaluationCommentEmail.new(@comment).to.each do |to|
|
|
Mailer.evaluation_comment(@comment, to).deliver_later
|
|
end
|
|
end
|
|
end
|