We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
33 lines
929 B
Ruby
33 lines
929 B
Ruby
class ProposalNotificationsController < ApplicationController
|
|
load_and_authorize_resource except: [:new]
|
|
|
|
def new
|
|
@proposal = Proposal.find(params[:proposal_id])
|
|
@notification = ProposalNotification.new(proposal_id: @proposal.id)
|
|
authorize! :new, @notification
|
|
end
|
|
|
|
def create
|
|
@notification = ProposalNotification.new(proposal_notification_params)
|
|
@proposal = Proposal.find(proposal_notification_params[:proposal_id])
|
|
if @notification.save
|
|
@proposal.users_to_notify.each do |user|
|
|
Notification.add(user, @notification)
|
|
end
|
|
redirect_to @notification, notice: I18n.t("flash.actions.create.proposal_notification")
|
|
else
|
|
render :new
|
|
end
|
|
end
|
|
|
|
def show
|
|
@notification = ProposalNotification.find(params[:id])
|
|
end
|
|
|
|
private
|
|
|
|
def proposal_notification_params
|
|
params.require(:proposal_notification).permit(:title, :body, :proposal_id)
|
|
end
|
|
end
|