We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
66 lines
1.4 KiB
Ruby
66 lines
1.4 KiB
Ruby
class Admin::NewslettersController < Admin::BaseController
|
|
def index
|
|
@newsletters = Newsletter.all
|
|
end
|
|
|
|
def show
|
|
@newsletter = Newsletter.find(params[:id])
|
|
end
|
|
|
|
def new
|
|
@newsletter = Newsletter.new
|
|
end
|
|
|
|
def create
|
|
@newsletter = Newsletter.new(newsletter_params)
|
|
|
|
if @newsletter.save
|
|
notice = t("admin.newsletters.create_success")
|
|
redirect_to [:admin, @newsletter], notice: notice
|
|
else
|
|
render :new
|
|
end
|
|
end
|
|
|
|
def edit
|
|
@newsletter = Newsletter.find(params[:id])
|
|
end
|
|
|
|
def update
|
|
@newsletter = Newsletter.find(params[:id])
|
|
|
|
if @newsletter.update(newsletter_params)
|
|
redirect_to [:admin, @newsletter], notice: t("admin.newsletters.update_success")
|
|
else
|
|
render :edit
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@newsletter = Newsletter.find(params[:id])
|
|
@newsletter.destroy!
|
|
|
|
redirect_to admin_newsletters_path, notice: t("admin.newsletters.delete_success")
|
|
end
|
|
|
|
def deliver
|
|
@newsletter = Newsletter.find(params[:id])
|
|
|
|
if @newsletter.valid?
|
|
@newsletter.delay.deliver
|
|
@newsletter.update!(sent_at: Time.current)
|
|
flash[:notice] = t("admin.newsletters.send_success")
|
|
else
|
|
flash[:error] = t("admin.segment_recipient.invalid_recipients_segment")
|
|
end
|
|
|
|
redirect_to [:admin, @newsletter]
|
|
end
|
|
|
|
private
|
|
|
|
def newsletter_params
|
|
params.require(:newsletter).permit(:subject, :segment_recipient, :from, :body)
|
|
end
|
|
end
|