db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
60 lines
1.9 KiB
Ruby
60 lines
1.9 KiB
Ruby
require "rails_helper"
|
|
|
|
describe HasOrders do
|
|
class FakeController < ActionController::Base; end
|
|
|
|
controller(FakeController) do
|
|
include HasOrders
|
|
has_orders ["created_at", "votes_count", "flags_count", "relevance"], only: :index
|
|
has_orders ->(c) { ["votes_count", "flags_count"] }, only: :new
|
|
|
|
def index
|
|
render plain: "#{@current_order} (#{@valid_orders.join(" ")})"
|
|
end
|
|
|
|
def new
|
|
render plain: "#{@current_order} (#{@valid_orders.join(" ")})"
|
|
end
|
|
end
|
|
|
|
it "displays all the orders except relevance when not searching" do
|
|
get :index
|
|
expect(response.body).to eq("created_at (created_at votes_count flags_count)")
|
|
end
|
|
|
|
it "allows specifying the orders via a lambda" do
|
|
get :new
|
|
expect(response.body).to eq("votes_count (votes_count flags_count)")
|
|
end
|
|
|
|
it "displays relevance when searching" do
|
|
get :index, params: { search: "ipsum" }
|
|
expect(response.body).to eq("created_at (created_at votes_count flags_count relevance)")
|
|
end
|
|
|
|
it "does not overwrite the has_orders options when doing several requests" do
|
|
get :index
|
|
# Since has_orders did valid_options.delete, the first call to :index might remove 'relevance' from
|
|
# the list by mistake.
|
|
get :index, params: { search: "ipsum" }
|
|
expect(response.body).to eq("created_at (created_at votes_count flags_count relevance)")
|
|
end
|
|
|
|
describe "the current order" do
|
|
it "defaults to the first one on the list" do
|
|
get :index
|
|
expect(response.body).to eq("created_at (created_at votes_count flags_count)")
|
|
end
|
|
|
|
it "can be changed by the order param" do
|
|
get :index, params: { order: "votes_count" }
|
|
expect(response.body).to eq("votes_count (created_at votes_count flags_count)")
|
|
end
|
|
|
|
it "defaults to the first one on the list if given a bogus order" do
|
|
get :index, params: { order: "foobar" }
|
|
expect(response.body).to eq("created_at (created_at votes_count flags_count)")
|
|
end
|
|
end
|
|
end
|