2cd4696244
Including them might lead to conflicts since two methods might have the same name. For example, we're getting some exceptions when taking screenshots of a failing test, because the method `image_path` from `ActionView::Helpers::AssetUrlHelper` has the same name as a method used to save the screenshot. Besides, we were including all helpers in places were only the `dom_id` method is used, and in other places where no helper methods were used at all. So we can just invoke `ActionView::RecordIdentifier.dom_id` directly.
70 lines
1.8 KiB
Ruby
70 lines
1.8 KiB
Ruby
shared_examples "image validations" do |imageable_factory|
|
|
include ImageablesHelper
|
|
|
|
let!(:image) { build(:image, imageable_factory.to_sym) }
|
|
let!(:imageable) { image.imageable }
|
|
let!(:acceptedcontenttypes) { imageable_accepted_content_types }
|
|
|
|
it "is valid" do
|
|
expect(image).to be_valid
|
|
end
|
|
|
|
it "is not valid without a title" do
|
|
image.title = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without an attachment" do
|
|
image.attachment = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is valid for all accepted content types" do
|
|
acceptedcontenttypes.each do |content_type|
|
|
extension = content_type.split("/").last
|
|
image.attachment = File.new("spec/fixtures/files/clippy.#{extension}")
|
|
|
|
expect(image).to be_valid
|
|
end
|
|
end
|
|
|
|
it "is not valid for png and gif image content types" do
|
|
["gif", "png"].each do |content_type|
|
|
extension = content_type.split("/").last
|
|
image.attachment = File.new("spec/fixtures/files/clippy.#{extension}")
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|
|
|
|
it "is not valid for attachments larger than imageable max_file_size definition" do
|
|
larger_size = Setting["uploads.images.max_size"].to_i.megabytes + 1.byte
|
|
allow(image).to receive(:attachment_file_size).and_return(larger_size)
|
|
|
|
expect(image).not_to be_valid
|
|
expect(image.errors[:attachment]).to include "must be in between 0 Bytes and 1 MB"
|
|
end
|
|
|
|
it "is not valid without a user_id" do
|
|
image.user_id = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a imageable_id" do
|
|
image.save!
|
|
image.imageable_id = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a imageable_type" do
|
|
image.save!
|
|
image.imageable_type = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|