227a5868b8
Using order links in this case causes an unusual interface, where we show filter links, then information about the number of results, and then order links. Whether or not this makes sense needs to be confirmed with usability tests. In any case, this is still way better than using `<select>` fields which automatically change to a new page, since they cause problems to keyboard users, are harder to select for touchscreen users, might confuse screen reader users who will notice a form but no way to submit it, and are not elements we generally use to let users choose the order of the records. For a more detailed explanation of these issues, check the commit message in the commit "Use order links to sort comments and topics" (just a few commits ago).
239 lines
7.7 KiB
Ruby
239 lines
7.7 KiB
Ruby
require "rails_helper"
|
|
|
|
describe "Moderate budget investments" do
|
|
let(:budget) { create(:budget) }
|
|
let(:heading) { create(:budget_heading, budget: budget, price: 666666) }
|
|
let(:mod) { create(:moderator) }
|
|
let!(:investment) { create(:budget_investment, heading: heading, author: create(:user)) }
|
|
|
|
scenario "Hiding an investment" do
|
|
login_as(mod.user)
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
accept_confirm { click_link "Hide" }
|
|
|
|
expect(page).to have_css(".faded", count: 2)
|
|
|
|
visit budget_investments_path(budget.id, heading_id: heading.id)
|
|
|
|
expect(page).not_to have_content(investment.title)
|
|
end
|
|
|
|
scenario "Hiding an investment's author" do
|
|
login_as(mod.user)
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
accept_confirm { click_link "Hide author" }
|
|
|
|
expect(page).to have_current_path(debates_path)
|
|
|
|
visit budget_investments_path(budget.id, heading_id: heading.id)
|
|
|
|
expect(page).not_to have_content(investment.title)
|
|
end
|
|
|
|
scenario "Can not hide own investment" do
|
|
investment.update!(author: mod.user)
|
|
login_as(mod.user)
|
|
|
|
visit budget_investment_path(budget, investment)
|
|
|
|
within "#budget_investment_#{investment.id}" do
|
|
expect(page).not_to have_link("Hide")
|
|
expect(page).not_to have_link("Hide author")
|
|
end
|
|
end
|
|
|
|
describe "/moderation/ screen" do
|
|
before do
|
|
login_as(mod.user)
|
|
end
|
|
|
|
describe "moderate in bulk" do
|
|
describe "When an investment has been selected for moderation" do
|
|
before do
|
|
visit moderation_budget_investments_path
|
|
|
|
within(".menu.simple") do
|
|
click_link "All"
|
|
end
|
|
|
|
within("#investment_#{investment.id}") do
|
|
check "budget_investment_#{investment.id}_check"
|
|
end
|
|
end
|
|
|
|
scenario "Hide the investment" do
|
|
accept_confirm { click_button "Hide budget investments" }
|
|
|
|
expect(page).not_to have_css("#investment_#{investment.id}")
|
|
|
|
click_link "Block users"
|
|
fill_in "email or name of user", with: investment.author.email
|
|
click_button "Search"
|
|
|
|
within "tr", text: investment.author.name do
|
|
expect(page).to have_link "Block"
|
|
end
|
|
end
|
|
|
|
scenario "Block the author" do
|
|
accept_confirm { click_button "Block authors" }
|
|
|
|
expect(page).not_to have_css("#investment_#{investment.id}")
|
|
|
|
click_link "Block users"
|
|
fill_in "email or name of user", with: investment.author.email
|
|
click_button "Search"
|
|
|
|
within "tr", text: investment.author.name do
|
|
expect(page).to have_content "Blocked"
|
|
end
|
|
end
|
|
|
|
scenario "Ignore the investment", :no_js do
|
|
click_button "Mark as viewed"
|
|
|
|
investment.reload
|
|
|
|
expect(investment).to be_ignored_flag
|
|
expect(investment).not_to be_hidden
|
|
expect(investment.author).not_to be_hidden
|
|
end
|
|
end
|
|
|
|
scenario "select all/none" do
|
|
create_list(:budget_investment, 2, heading: heading, author: create(:user))
|
|
|
|
visit moderation_budget_investments_path
|
|
|
|
within(".js-check") { click_on "All" }
|
|
|
|
expect(all("input[type=checkbox]")).to all(be_checked)
|
|
|
|
within(".js-check") { click_on "None" }
|
|
|
|
all("input[type=checkbox]").each do |checkbox|
|
|
expect(checkbox).not_to be_checked
|
|
end
|
|
end
|
|
|
|
scenario "remembering page, filter and order" do
|
|
stub_const("#{ModerateActions}::PER_PAGE", 2)
|
|
create_list(:budget_investment, 4, heading: heading, author: create(:user))
|
|
|
|
visit moderation_budget_investments_path(filter: "all", page: "2", order: "created_at")
|
|
|
|
accept_confirm { click_button "Mark as viewed" }
|
|
|
|
expect(page).to have_link "Most recent", class: "is-active"
|
|
expect(page).to have_link "Most flagged"
|
|
|
|
expect(page).to have_current_path(/filter=all/)
|
|
expect(page).to have_current_path(/page=2/)
|
|
expect(page).to have_current_path(/order=created_at/)
|
|
end
|
|
end
|
|
|
|
scenario "Current filter is properly highlighted" do
|
|
visit moderation_budget_investments_path
|
|
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Marked as viewed")
|
|
|
|
visit moderation_budget_investments_path(filter: "all")
|
|
|
|
within(".menu.simple") do
|
|
expect(page).not_to have_link("All")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).to have_link("Marked as viewed")
|
|
end
|
|
|
|
visit moderation_budget_investments_path(filter: "pending_flag_review")
|
|
|
|
within(".menu.simple") do
|
|
expect(page).to have_link("All")
|
|
expect(page).not_to have_link("Pending")
|
|
expect(page).to have_link("Marked as viewed")
|
|
end
|
|
|
|
visit moderation_budget_investments_path(filter: "with_ignored_flag")
|
|
|
|
within(".menu.simple") do
|
|
expect(page).to have_link("All")
|
|
expect(page).to have_link("Pending")
|
|
expect(page).not_to have_link("Marked as viewed")
|
|
end
|
|
end
|
|
|
|
scenario "Filtering investments" do
|
|
create(:budget_investment, heading: heading, title: "Books investment")
|
|
create(:budget_investment, :flagged, heading: heading, title: "Non-selected investment")
|
|
create(:budget_investment, :hidden, heading: heading, title: "Hidden investment")
|
|
create(:budget_investment, :flagged, :with_ignored_flag, heading: heading, title: "Ignored investment")
|
|
|
|
visit moderation_budget_investments_path(filter: "all")
|
|
|
|
expect(page).to have_content("Books investment")
|
|
expect(page).to have_content("Non-selected investment")
|
|
expect(page).not_to have_content("Hidden investment")
|
|
expect(page).to have_content("Ignored investment")
|
|
|
|
visit moderation_budget_investments_path(filter: "pending_flag_review")
|
|
|
|
expect(page).not_to have_content("Books investment")
|
|
expect(page).to have_content("Non-selected investment")
|
|
expect(page).not_to have_content("Hidden investment")
|
|
expect(page).not_to have_content("Ignored investment")
|
|
|
|
visit moderation_budget_investments_path(filter: "with_ignored_flag")
|
|
|
|
expect(page).not_to have_content("Books investment")
|
|
expect(page).not_to have_content("Non-selected investment")
|
|
expect(page).not_to have_content("Hidden investment")
|
|
expect(page).to have_content("Ignored investment")
|
|
end
|
|
|
|
scenario "sorting investments" do
|
|
flagged_investment = create(:budget_investment,
|
|
heading: heading,
|
|
title: "Flagged investment",
|
|
created_at: Time.current - 1.day,
|
|
flags_count: 5
|
|
)
|
|
|
|
flagged_new_investment = create(:budget_investment,
|
|
heading: heading,
|
|
title: "Flagged new investment",
|
|
created_at: Time.current - 12.hours,
|
|
flags_count: 3
|
|
)
|
|
|
|
latest_investment = create(:budget_investment,
|
|
heading: heading,
|
|
title: "Latest investment",
|
|
created_at: Time.current
|
|
)
|
|
|
|
visit moderation_budget_investments_path(order: "created_at")
|
|
|
|
expect(flagged_new_investment.title).to appear_before(flagged_investment.title)
|
|
|
|
visit moderation_budget_investments_path(order: "flags")
|
|
|
|
expect(flagged_investment.title).to appear_before(flagged_new_investment.title)
|
|
|
|
visit moderation_budget_investments_path(filter: "all", order: "created_at")
|
|
|
|
expect(latest_investment.title).to appear_before(flagged_new_investment.title)
|
|
expect(flagged_new_investment.title).to appear_before(flagged_investment.title)
|
|
|
|
visit moderation_budget_investments_path(filter: "all", order: "flags")
|
|
|
|
expect(flagged_investment.title).to appear_before(flagged_new_investment.title)
|
|
expect(flagged_new_investment.title).to appear_before(latest_investment.title)
|
|
end
|
|
end
|
|
end
|