consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
1fa3cf8ce7e479aabb29d0746773fa40a6559dd1
grecia/app/models
History
Javi Martín 413d0ed9be Return the persisted line in add_investment 
This method was returning a boolean value and caused a
`Naming/PredicateMethod` when upgrading rubocop.

So, instead, we're returning the created line when it was successfully
created, and `nil` when it wasn't.

Having said that, I'm not sure why we added the `.persisted?` back in
commit 3eb22ab7b since as far as I can tell we don't use the return
value for anything. The test added in commit da43e9e2e for this change
passes if we simply return `lines.create(investment: investment)`.

For now I'm leaving the `persisted?` check just in case, but removing it
might be fine.
2025-11-05 14:27:11 +01:00
..
abilities
Adapt 'show' view for open questions without options
2025-10-15 15:52:14 +02:00
ahoy
Remove the ahoy_events table
2024-11-13 15:55:20 +01:00
banner
…
budget
Return the persisted line in add_investment
2025-11-05 14:27:11 +01:00
ckeditor
Fix deleted file case in CKEditor
2022-02-23 18:21:38 +01:00
comment
Add experimental machine learning
2021-08-16 16:31:04 +02:00
concerns
Refactor notifiable_available? method
2025-11-05 14:27:11 +01:00
cookies
Allow administrators to define the cookies vendors the application uses
2025-01-23 17:03:30 +01:00
custom
Use load instead of require_dependency in custom files
2024-04-11 19:08:02 +02:00
dashboard
Add and apply Rails/EnumHash rubocop rule
2024-10-10 09:56:44 +02:00
legislation
Add and apply Rails/OrderArguments rubocop rule
2025-11-05 11:51:23 +01:00
local_census_records
Explicitly add csv to Gemfile
2025-10-22 21:15:58 +02:00
milestone
…
officing
Use a date field to select the date of birth
2024-11-12 15:15:34 +01:00
poll
Add and apply Rails/OrderArguments rubocop rule
2025-11-05 11:51:23 +01:00
proposal
Add experimental machine learning
2021-08-16 16:31:04 +02:00
sdg
Add and apply Rails/EnumHash rubocop rule
2024-10-10 09:56:44 +02:00
setting
Extract model to handle locales settings
2024-06-05 16:10:56 +02:00
site_customization
Add and apply Rails/OrderArguments rubocop rule
2025-11-05 11:51:23 +01:00
verification
Use Verification::Email.valid_token? instead of .find
2025-11-05 14:27:11 +01:00
widget
Add and apply Rails/OrderArguments rubocop rule
2025-11-05 11:51:23 +01:00
.keep
…
ability.rb
Use just one action to hide users
2021-12-30 15:50:02 +01:00
active_poll.rb
…
activity.rb
Add lambda to the validations that use model constants
2022-03-22 15:52:36 +01:00
admin_notification.rb
Send an empty CSV file for invalid user segments
2025-04-02 13:21:45 +02:00
administrator.rb
Fix crash deleting admin with assigned budgets
2022-05-03 18:39:42 +02:00
application_record.rb
Make it easier to customize validations
2022-03-24 17:05:35 +01:00
audit.rb
Use a different controller for investment audits
2019-11-05 13:03:45 +01:00
banner.rb
Use excluding instead of where.not(id:
2024-07-22 18:35:35 +02:00
budget_administrator.rb
Apply Layout/LeadingBlankLines rubocop rule
2019-10-26 13:03:48 +02:00
budget_valuator.rb
…
budget.rb
Add new GraphQL types for budget investments
2024-09-30 11:14:01 +02:00
comment_notifier.rb
Add and apply Style/SoleNestedConditional rule
2021-09-03 11:49:53 +02:00
comment.rb
Add new GraphQL types for budget investments
2024-09-30 11:14:01 +02:00
community.rb
Use hash conditions instead of SQL's IN
2020-07-08 18:34:58 +02:00
cookies.rb
Allow administrators to define the cookies vendors the application uses
2025-01-23 17:03:30 +01:00
dashboard.rb
…
debate.rb
Add and apply Rails/WhereRange rubocop rule
2024-07-05 17:11:29 +02:00
direct_message.rb
Use Date#all_day in DirectMessage.today
2020-04-27 19:26:37 +02:00
direct_upload.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
document.rb
Remove pdf metadata
2023-11-22 14:44:24 +01:00
evaluation_comment_notifier.rb
…
failed_census_call.rb
…
flag.rb
…
follow.rb
Avoid a brakeman security warning
2021-04-13 13:52:18 +02:00
geozone.rb
Support different colors and headings on each feature
2024-12-23 17:35:33 +01:00
geozones_poll.rb
Apply Rails/HasAndBelongsToMany rubocop rule
2019-10-25 19:29:12 +02:00
i18n_content_translation.rb
Simplify method to get existing locales
2024-06-05 16:10:56 +02:00
i18n_content.rb
Allow different locales per tenant
2024-06-05 16:10:56 +02:00
identity.rb
…
image.rb
Bump rubocop from 1.56.4 to 1.61.0
2024-04-02 16:31:10 +02:00
legislation.rb
…
link.rb
…
local_census_record.rb
Use aria-label in admin table actions
2021-09-20 20:27:37 +02:00
lock.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
machine_learning_info.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
machine_learning_job.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
machine_learning.rb
Add and apply Style/RedundantBegin rubocop rule
2024-10-30 15:57:44 +01:00
manager.rb
…
map_location.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
milestone.rb
Add new GraphQL type for milestones
2024-09-30 11:14:01 +02:00
ml_summary_comment.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
moderator.rb
…
newsletter.rb
Send an empty CSV file for invalid user segments
2025-04-02 13:21:45 +02:00
notification.rb
Refactor notifiable_available? method
2025-11-05 14:27:11 +01:00
organization.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
poll.rb
Allow blank votes in polls via web
2025-08-14 13:06:43 +02:00
progress_bar.rb
Add and apply Rails/EnumHash rubocop rule
2024-10-10 09:56:44 +02:00
proposal_notification.rb
Use excluding instead of where.not(id:
2024-07-22 18:35:35 +02:00
proposal.rb
Don't hide records during a system test
2025-04-01 14:53:27 +02:00
related_content_score.rb
Apply Layout/RedundantLineBreak rule to short lines
2021-09-03 11:49:53 +02:00
related_content.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
remote_translation.rb
Add and apply Style/ArgumentsForwarding rule
2024-04-11 17:59:40 +02:00
report.rb
Apply rubocop rules to freeze constants
2019-10-26 13:21:36 +02:00
sdg.rb
Add SDG goal model
2020-12-02 12:13:02 +01:00
setting.rb
Add setting to require consent for notifications
2025-10-09 10:53:00 +02:00
signature_sheet.rb
Add and apply Style/RedundantRegexpArgument RuboCop rule
2024-10-10 09:47:47 +02:00
signature.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
site_customization.rb
…
tag_cloud.rb
Add and apply MultilineMethodCallIndentation rule
2023-08-18 14:56:16 +02:00
tag.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
tagging.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
tenant.rb
Add and apply Rails/EnumHash rubocop rule
2024-10-10 09:56:44 +02:00
topic.rb
Apply Rails/InverseOf rubocop rule
2019-10-25 19:29:12 +02:00
user.rb
Don't display public activity by default when requiring consent
2025-10-09 10:56:21 +02:00
valuator_group.rb
…
valuator.rb
…
verified_user.rb
…
visit.rb
Remove the ahoy_events table
2024-11-13 15:55:20 +01:00
votation_type.rb
Exclude open-ended questions from managing physical votes
2025-10-16 14:31:16 +02:00
vote.rb
…
web_section.rb
Add sdg management header controller
2021-02-26 16:16:51 +01:00
widget.rb
Simplify widget table prefix
2021-01-12 14:50:37 +01:00