1693aa5d9c
This way we remove duplication.
Note that to check whether to render the button to remove a marker,
we're checking whether the map location belongs to a mappable. This
means we're changing the code that renders the map in the "new proposal"
and "new investment" forms so the map location belongs to a proposal or
investment. We're association the map location to a new record because
writing something like:
```
def map_location
proposal.map_location || MapLocation.new(proposal: proposal)
end
```
Would change the `proposal` object because of the way Rails treats
non-persisted `has_one` associations. Although probably safe in this
case, changing an object when rendering a view could have side effects.
Also note that we're changing the HTML ID of the map element from
`admin-map` to `new_map_location` (the latter is returned by the
`dom_id` method). We were only using this ID in tests since commit
289426c1c, so changing it doesn't really affect us.
50 lines
1.4 KiB
Ruby
50 lines
1.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Budgets::Investments::FormComponent do
|
|
include Rails.application.routes.url_helpers
|
|
|
|
let(:budget) { create(:budget) }
|
|
before { sign_in(create(:user)) }
|
|
|
|
around do |example|
|
|
with_request_url(new_budget_investment_path(budget)) { example.run }
|
|
end
|
|
|
|
describe "accept terms of services field" do
|
|
it "is shown for new investments" do
|
|
investment = build(:budget_investment, budget: budget)
|
|
|
|
render_inline Budgets::Investments::FormComponent.new(
|
|
investment,
|
|
url: budget_investments_path(budget)
|
|
)
|
|
|
|
expect(page).to have_field "I agree to the Privacy Policy and the Terms and conditions of use"
|
|
end
|
|
|
|
it "is not shown for existing investments" do
|
|
investment = create(:budget_investment, budget: budget)
|
|
|
|
render_inline Budgets::Investments::FormComponent.new(
|
|
investment,
|
|
url: budget_investment_path(budget, investment)
|
|
)
|
|
|
|
expect(page).not_to have_field "I agree to the Privacy Policy and the Terms and conditions of use"
|
|
end
|
|
end
|
|
|
|
describe "map" do
|
|
it "renders a button to remove the map marker" do
|
|
Setting["feature.map"] = true
|
|
|
|
render_inline Budgets::Investments::FormComponent.new(
|
|
budget.investments.new,
|
|
url: budget_investments_path(budget)
|
|
)
|
|
|
|
expect(page).to have_button "Remove map marker"
|
|
end
|
|
end
|
|
end
|