This way we remove duplication.
Note that to check whether to render the button to remove a marker,
we're checking whether the map location belongs to a mappable. This
means we're changing the code that renders the map in the "new proposal"
and "new investment" forms so the map location belongs to a proposal or
investment. We're association the map location to a new record because
writing something like:
```
def map_location
proposal.map_location || MapLocation.new(proposal: proposal)
end
```
Would change the `proposal` object because of the way Rails treats
non-persisted `has_one` associations. Although probably safe in this
case, changing an object when rendering a view could have side effects.
Also note that we're changing the HTML ID of the map element from
`admin-map` to `new_map_location` (the latter is returned by the
`dom_id` method). We were only using this ID in tests since commit
289426c1c, so changing it doesn't really affect us.
18 lines
589 B
Plaintext
18 lines
589 B
Plaintext
<div class="row">
|
|
<div class="small-12 column">
|
|
<%= form_for map_location, url: admin_update_map_path, method: :put, html: { id: "map-form" } do |f| %>
|
|
<%= render_map(map_location, form: f) %>
|
|
<%= f.hidden_field :latitude %>
|
|
<%= f.hidden_field :longitude %>
|
|
<%= f.hidden_field :zoom %>
|
|
<%= hidden_field_tag :tab, tab if tab %>
|
|
|
|
<div class="small-12 medium-6 large-4 margin-top">
|
|
<%= submit_tag t("admin.settings.index.map.form.submit"),
|
|
class: "button hollow expanded" %>
|
|
</div>
|
|
|
|
<% end %>
|
|
</div>
|
|
</div>
|