We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
13 lines
298 B
Ruby
13 lines
298 B
Ruby
class MergedCommentTree < CommentTree
|
|
attr_reader :commentables
|
|
|
|
def initialize(commentables, page, order = "confidence_score")
|
|
@commentables = commentables
|
|
super(commentables.first, page, order)
|
|
end
|
|
|
|
def base_comments
|
|
Comment.where(commentable: commentables.flatten)
|
|
end
|
|
end
|