db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
109 lines
3.0 KiB
Ruby
109 lines
3.0 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Vote do
|
|
describe "#for_debates" do
|
|
it "does not returns votes for other votables" do
|
|
debate = create(:debate)
|
|
create(:vote, votable: create(:comment))
|
|
|
|
expect(Vote.for_debates(debate).count).to eq(0)
|
|
end
|
|
|
|
it "returns votes only for debates in parameters" do
|
|
debate1 = create(:debate, voters: [create(:user)])
|
|
debate2 = create(:debate)
|
|
|
|
expect(Vote.for_debates(debate1).count).to eq(1)
|
|
expect(Vote.for_debates(debate2).count).to eq(0)
|
|
end
|
|
|
|
it "accepts more than 1 debate" do
|
|
debate1 = create(:debate, voters: [create(:user)])
|
|
debate2 = create(:debate)
|
|
debate3 = create(:debate, voters: [create(:user)])
|
|
|
|
expect(Vote.for_debates([debate1, debate2]).count).to eq(1)
|
|
expect(Vote.for_debates([debate1, debate3]).count).to eq(2)
|
|
end
|
|
end
|
|
|
|
describe "#value" do
|
|
it "returns vote flag" do
|
|
vote = create(:vote, vote_flag: true)
|
|
expect(vote.value).to eq(true)
|
|
|
|
vote = create(:vote, vote_flag: false)
|
|
expect(vote.value).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe "public_for_api scope" do
|
|
it "returns votes on debates" do
|
|
debate = create(:debate)
|
|
vote = create(:vote, votable: debate)
|
|
|
|
expect(Vote.public_for_api).to eq [vote]
|
|
end
|
|
|
|
it "blocks votes on hidden debates" do
|
|
create(:vote, votable: create(:debate, :hidden))
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
|
|
it "returns votes on proposals" do
|
|
proposal = create(:proposal)
|
|
vote = create(:vote, votable: proposal)
|
|
|
|
expect(Vote.public_for_api).to eq [vote]
|
|
end
|
|
|
|
it "blocks votes on hidden proposals" do
|
|
create(:vote, votable: create(:proposal, :hidden))
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
|
|
it "returns votes on comments" do
|
|
comment = create(:comment)
|
|
vote = create(:vote, votable: comment)
|
|
|
|
expect(Vote.public_for_api).to eq [vote]
|
|
end
|
|
|
|
it "blocks votes on hidden comments" do
|
|
create(:vote, votable: create(:comment, :hidden))
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
|
|
it "blocks votes on comments on hidden proposals" do
|
|
hidden_proposal = create(:proposal, :hidden)
|
|
comment_on_hidden_proposal = create(:comment, commentable: hidden_proposal)
|
|
create(:vote, votable: comment_on_hidden_proposal)
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
|
|
it "blocks votes on comments on hidden debates" do
|
|
hidden_debate = create(:debate, :hidden)
|
|
comment_on_hidden_debate = create(:comment, commentable: hidden_debate)
|
|
create(:vote, votable: comment_on_hidden_debate)
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
|
|
it "blocks any other kind of votes" do
|
|
create(:vote, votable: create(:budget_investment))
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
|
|
it "blocks votes without votable" do
|
|
build(:vote, votable: nil).save!(validate: false)
|
|
|
|
expect(Vote.public_for_api).to be_empty
|
|
end
|
|
end
|
|
end
|