db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
84 lines
2.8 KiB
Ruby
84 lines
2.8 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Poll::PartialResult do
|
|
describe "validations" do
|
|
it "validates that the answers are included in the Poll::Question's list" do
|
|
question = create(:poll_question)
|
|
create(:poll_question_answer, title: "One", question: question)
|
|
create(:poll_question_answer, title: "Two", question: question)
|
|
create(:poll_question_answer, title: "Three", question: question)
|
|
|
|
expect(build(:poll_partial_result, question: question, answer: "One")).to be_valid
|
|
expect(build(:poll_partial_result, question: question, answer: "Two")).to be_valid
|
|
expect(build(:poll_partial_result, question: question, answer: "Three")).to be_valid
|
|
|
|
expect(build(:poll_partial_result, question: question, answer: "Four")).not_to be_valid
|
|
end
|
|
end
|
|
|
|
describe "logging changes" do
|
|
it "updates amount_log if amount changes" do
|
|
partial_result = create(:poll_partial_result, amount: 33)
|
|
|
|
expect(partial_result.amount_log).to eq("")
|
|
|
|
partial_result.amount = 33
|
|
partial_result.save!
|
|
partial_result.amount = 32
|
|
partial_result.save!
|
|
partial_result.amount = 34
|
|
partial_result.save!
|
|
|
|
expect(partial_result.amount_log).to eq(":33:32")
|
|
end
|
|
|
|
it "updates officer_assignment_id_log if amount changes" do
|
|
partial_result = create(:poll_partial_result, amount: 33)
|
|
|
|
expect(partial_result.amount_log).to eq("")
|
|
expect(partial_result.officer_assignment_id_log).to eq("")
|
|
|
|
partial_result.amount = 33
|
|
partial_result.officer_assignment = create(:poll_officer_assignment, id: 10)
|
|
partial_result.save!
|
|
|
|
partial_result.amount = 32
|
|
partial_result.officer_assignment = create(:poll_officer_assignment, id: 20)
|
|
partial_result.save!
|
|
|
|
partial_result.amount = 34
|
|
partial_result.officer_assignment = create(:poll_officer_assignment, id: 30)
|
|
partial_result.save!
|
|
|
|
expect(partial_result.amount_log).to eq(":33:32")
|
|
expect(partial_result.officer_assignment_id_log).to eq(":10:20")
|
|
end
|
|
|
|
it "updates author_id if amount changes" do
|
|
partial_result = create(:poll_partial_result, amount: 33)
|
|
|
|
expect(partial_result.amount_log).to eq("")
|
|
expect(partial_result.author_id_log).to eq("")
|
|
|
|
author1 = create(:poll_officer).user
|
|
author2 = create(:poll_officer).user
|
|
author3 = create(:poll_officer).user
|
|
|
|
partial_result.amount = 33
|
|
partial_result.author_id = author1.id
|
|
partial_result.save!
|
|
|
|
partial_result.amount = 32
|
|
partial_result.author_id = author2.id
|
|
partial_result.save!
|
|
|
|
partial_result.amount = 34
|
|
partial_result.author_id = author3.id
|
|
partial_result.save!
|
|
|
|
expect(partial_result.amount_log).to eq(":33:32")
|
|
expect(partial_result.author_id_log).to eq(":#{author1.id}:#{author2.id}")
|
|
end
|
|
end
|
|
end
|