b52ceb2c78
We were using helper methods inside the model; we might as well include them in the model and use them from anywhere else. Note we're using a different logic for images and documents methods. That's because for images the logic was defined in the helper methods, but for documents the logic is defined in the Documentable concern. In the past, different documentable classes allowed different content types, while imageable classes have always allowed the same content types. I'm not sure which method is better; for now, I'm leaving it the way it was (except for the fact that we're removing the helper methods).
67 lines
1.7 KiB
Ruby
67 lines
1.7 KiB
Ruby
shared_examples "image validations" do |imageable_factory|
|
|
let!(:image) { build(:image, imageable_factory.to_sym) }
|
|
let!(:acceptedcontenttypes) { Image.accepted_content_types }
|
|
|
|
it "is valid" do
|
|
expect(image).to be_valid
|
|
end
|
|
|
|
it "is not valid without a title" do
|
|
image.title = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without an attachment" do
|
|
image.attachment = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is valid for all accepted content types" do
|
|
acceptedcontenttypes.each do |content_type|
|
|
extension = content_type.split("/").last
|
|
image.attachment = File.new("spec/fixtures/files/clippy.#{extension}")
|
|
|
|
expect(image).to be_valid
|
|
end
|
|
end
|
|
|
|
it "is not valid for png and gif image content types" do
|
|
["gif", "png"].each do |content_type|
|
|
extension = content_type.split("/").last
|
|
image.attachment = File.new("spec/fixtures/files/clippy.#{extension}")
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|
|
|
|
it "is not valid for attachments larger than imageable max_file_size definition" do
|
|
larger_size = Setting["uploads.images.max_size"].to_i.megabytes + 1.byte
|
|
allow(image).to receive(:attachment_file_size).and_return(larger_size)
|
|
|
|
expect(image).not_to be_valid
|
|
expect(image.errors[:attachment]).to include "must be in between 0 Bytes and 1 MB"
|
|
end
|
|
|
|
it "is not valid without a user_id" do
|
|
image.user_id = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a imageable_id" do
|
|
image.save!
|
|
image.imageable_id = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
|
|
it "is not valid without a imageable_type" do
|
|
image.save!
|
|
image.imageable_type = nil
|
|
|
|
expect(image).not_to be_valid
|
|
end
|
|
end
|