03ef20bfde
Both these objects where using/setting a variable called valid_orders. As a results, some specs where becoming flacky (features/budgets/investments_spec.rb, balloting phase). By putting them together, there is no `valid_orders` variable any more (everything is @valid_orders) and the flackyness is gone.
53 lines
1.5 KiB
Ruby
53 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe 'HasOrders' do
|
|
|
|
class FakeController < ActionController::Base; end
|
|
|
|
controller(FakeController) do
|
|
include HasOrders
|
|
has_orders ['created_at', 'votes_count', 'flags_count', 'relevance'], only: :index
|
|
has_orders -> (c) { ['votes_count', 'flags_count'] }, only: :new
|
|
|
|
def index
|
|
render text: "#{@current_order} (#{@valid_orders.join(' ')})"
|
|
end
|
|
|
|
def new
|
|
render text: "#{@current_order} (#{@valid_orders.join(' ')})"
|
|
end
|
|
end
|
|
|
|
it "displays all the orders except relevance when not searching" do
|
|
get :index
|
|
expect(response.body).to eq('created_at (created_at votes_count flags_count)')
|
|
end
|
|
|
|
it "allows specifying the orders via a lambda" do
|
|
get :new
|
|
expect(response.body).to eq('votes_count (votes_count flags_count)')
|
|
end
|
|
|
|
it "displays relevance when searching" do
|
|
get :index, search: 'ipsum'
|
|
expect(response.body).to eq('created_at (created_at votes_count flags_count relevance)')
|
|
end
|
|
|
|
describe "the current order" do
|
|
it "defaults to the first one on the list" do
|
|
get :index
|
|
expect(response.body).to eq('created_at (created_at votes_count flags_count)')
|
|
end
|
|
|
|
it "can be changed by the order param" do
|
|
get :index, order: 'votes_count'
|
|
expect(response.body).to eq('votes_count (created_at votes_count flags_count)')
|
|
end
|
|
|
|
it "defaults to the first one on the list if given a bogus order" do
|
|
get :index, order: 'foobar'
|
|
expect(response.body).to eq('created_at (created_at votes_count flags_count)')
|
|
end
|
|
end
|
|
end
|